psu-ng: Not clearing faults if power supply missing
The faultLogged variable is not set to false when clearFaults() is
called if the power supply is not present. This variable is checked to
see if an error should be logged if the power supply is not present.
Always clear this variable, to allow for logging a new error on power
state changes from off to on.
Tested:
obmcutil poweron with all power supplies present.
Remove power supply, verify error logged for missing power supply.
obmcutil poweroff
obmcutil poweron
Verify new error logged for missing power supply.
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
Change-Id: Ibb12fe90f0a22e7c44144d4d5516fedff35a4e12
diff --git a/phosphor-power-supply/power_supply.cpp b/phosphor-power-supply/power_supply.cpp
index 85248a5..72403ed 100644
--- a/phosphor-power-supply/power_supply.cpp
+++ b/phosphor-power-supply/power_supply.cpp
@@ -137,6 +137,7 @@
void PowerSupply::clearFaults()
{
+ faultLogged = false;
// The PMBus device driver does not allow for writing CLEAR_FAULTS
// directly. However, the pmbus hwmon device driver code will send a
// CLEAR_FAULTS after reading from any of the hwmon "files" in sysfs, so
@@ -151,7 +152,6 @@
statusMFR = 0;
vinUVFault = false;
readFail = 0;
- faultLogged = false;
try
{