Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-power / 891112db3d77d415a29776feb529dfb2644c7f55
commit891112db3d77d415a29776feb529dfb2644c7f55[log] [tgz]
authorJayanth Othayoth <ojayanth@gmail.com>Sun Jun 08 10:09:47 2025 -0500
committerJayanth Othayoth <ojayanth@gmail.com>Mon Jul 21 11:53:46 2025 -0500
tree515ff19547979da61e1c020b22f9ed30de5b4db3
parentce1119ade9ea0cc2f32f83c8d27a6f8efd7b763f [diff]
clang-tidy: wrap test_utils.hpp in cpp

Introduced a temporary wrapper `.cpp` file that includes
`test_utils.hpp` to allow clang-tidy to analyze the header
in the correct compilation context.

clang-tidy was failing to resolve includes like `actions/action.hpp`
when run directly on `test_utils.hpp`, due to missing include path
context in the compilation database. This is a known limitation when
analyzing header files outside of a translation unit.

By wrapping the header in a `.cpp` file and running clang-tidy on
that instead, we ensure that all include paths and macros are
correctly applied, resolving false-positive errors and improving
static analysis reliability.

Change-Id: I9a72d14ab844c0b53eebea6229e0bc22ff8aa273
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
3 files changed
tree: 515ff19547979da61e1c020b22f9ed30de5b4db3
  1. cold-redundancy/
  2. example/
  3. org/
  4. phosphor-power-sequencer/
  5. phosphor-power-supply/
  6. phosphor-regulators/
  7. power-sequencer/
  8. power-supply/
  9. services/
  10. subprojects/
  11. test/
  12. tools/
  13. .clang-format
  14. .clang-tidy-ignore
  15. .gitignore
  16. .shellcheck
  17. compatible_system_types_finder.cpp
  18. compatible_system_types_finder.hpp
  19. dbus_interfaces_finder.cpp
  20. dbus_interfaces_finder.hpp
  21. device.hpp
  22. device_monitor.hpp
  23. elog-errors.hpp
  24. file_descriptor.hpp
  25. format_utils.hpp
  26. gpio.cpp
  27. gpio.hpp
  28. LICENSE
  29. meson.build
  30. meson.options
  31. names_values.hpp
  32. OWNERS
  33. pmbus.cpp
  34. pmbus.hpp
  35. README.md
  36. temporary_file.cpp
  37. temporary_file.hpp
  38. temporary_subdirectory.cpp
  39. temporary_subdirectory.hpp
  40. types.hpp
  41. utility.cpp
  42. utility.hpp
README.md

phosphor-power

Overview

This repository contains applications for configuring and monitoring devices that deliver power to the system.

Actively-maintained applications:

  • cold-redundancy: Application that makes power supplies work in Cold Redundancy mode and rotates them at intervals.
  • phosphor-power-sequencer: JSON-driven application that powers the chassis on/off and monitors the power sequencer device.
  • phosphor-power-supply: Next generation power supply monitoring application.
  • phosphor-regulators: JSON-driven application that configures and monitors voltage regulators.
  • tools/power-utils: Power supply utilities.

Legacy applications:

  • power-sequencer: Original power sequencer monitoring application.
  • power-supply: Original power supply monitoring application.

Build

To build all applications in this repository:

  meson setup build
  ninja -C build

To clean the repository and remove all build output:

  rm -rf build

You can specify meson options to customize the build process. For example, you can specify:

  • Which applications to build and install.
  • Application-specific configuration data, such as power sequencer type.
  • Whether to build tests.

Power Supply Monitor and Util JSON config

Several applications in this repository require a PSU JSON config to run. The JSON config file provides information for:

  • Where to access the pmbus attributes
  • Which attribute file in pmbus maps to which property and interface in D-Bus
  • Which kernel device directory is used on which PSU

There is an example psu.json to describe the necessary configurations.

  • inventoryPMBusAccessType defines the pmbus access type, which tells the service which sysfs type to use to read the attributes. The possible values are:

    • Base: The base dir, e.g. /sys/bus/i2c/devices/3-0069/
    • Hwmon: The hwmon dir, e.g. /sys/bus/i2c/devices/3-0069/hwmon/hwmonX/
    • Debug: The pmbus debug dir, e.g. /sys/kernel/debug/pmbus/hwmonX/
    • DeviceDebug: The device debug dir, e.g. /sys/kernel/debug/<driver>.<instance>/
    • HwmonDeviceDebug: The hwmon device debug dir, e.g. /sys/kernel/debug/pmbus/hwmonX/cffps1/

  • fruConfigs defines the mapping between the attribute file and the FRU inventory interface and property. The configuration example below indicates that the service will read part_number attribute file from a directory specified by the above pmbus access type, and assign to PartNumber property in xyz.openbmc_project.Inventory.Decorator.Asset interface.

      "fruConfigs": [
    {
      "propertyName": "PartNumber",
      "fileName": "part_number",
      "interface": "xyz.openbmc_project.Inventory.Decorator.Asset"
    }
  ]

  • psuDevices defines the kernel device dir for each PSU in inventory. The configuration example below indicates that powersupply0's device is located in /sys/bus/i2c/devices/3-0069.

      "psuDevices": {
    "/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply0" : "/sys/bus/i2c/devices/3-0069",
  }