Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-power / 9bc5f7681c26df8fbd6e01cd0ea15c8842a2c133
commit9bc5f7681c26df8fbd6e01cd0ea15c8842a2c133[log] [tgz]
authorBrandon Wyman <bjwyman@gmail.com>Tue Jul 12 20:47:03 2022 +0000
committerBrandon Wyman <bjwyman@gmail.com>Thu Jul 14 16:40:31 2022 +0000
tree8564ccf99de56e11e7b1f6f5396bb710633536e6
parentaca86d059b92947cd5e430a5d4d1f1fee2ff5b89 [diff]
psu-ng: Fix false brownout fault logging

The hasVINUVCount only matters if a power supply is present. Issues
noticed on an internal system test on Rainier 1S4U, during the
replacement of a power supply with a fan fault, a 110000AC PEL
(brownout) was logged.

If we have two power supplies total, then have a fault on one of them,
in the act of replacing it, we will remove input voltage, and then
remove the power supply. If the power supply is missing, and it
previously had an input under-voltage fault, it does not really count
against a brownout anymore, other than now being missing. We already
account for present power supplies, the issue appears to be with
counting VIN_UV faults against missing power supplies. Only count a
power supply as VIN_UV faulted if it is present.

Tested:
    Simulated Rainier 2S2U
      1. Fake fan fault psu0.
      2. Fake VIN_UV fault psu0 (remove power).
      3. Remove psu0
      4. Install psu0, apply power (clear all faults).
      5. Verify no brownout fault logged.
      6. Repeat for psu1
    Simulated Rainier 2S2U
      Re-run brownout fault script.
      Verify brownout fault logged.
    Real Rainier 1S4U
      1. Remove psu2.
      2. Insert obstruction to block fan.
      3. Install psu2.
      4. Wait for PSU fan fault to be logged.
      5. Remove psu2.
      6. Remove fan obstruction from PSU.
      7. Install psu2.
      8. Verify no brownout fault logged.
      9. Repeat for psu3.

Change-Id: I809112ca0afc0b8294b62a62cdcc147b51ccc6e6
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
1 file changed
tree: 8564ccf99de56e11e7b1f6f5396bb710633536e6
  1. cold-redundancy/
  2. example/
  3. org/
  4. phosphor-power-sequencer/
  5. phosphor-power-supply/
  6. phosphor-regulators/
  7. power-sequencer/
  8. power-supply/
  9. services/
  10. test/
  11. tools/
  12. .clang-format
  13. .gitignore
  14. .shellcheck
  15. argument.hpp
  16. device.hpp
  17. device_monitor.hpp
  18. elog-errors.hpp
  19. file_descriptor.hpp
  20. gpio.cpp
  21. gpio.hpp
  22. LICENSE
  23. MAINTAINERS
  24. meson.build
  25. meson_options.txt
  26. names_values.hpp
  27. OWNERS
  28. pmbus.cpp
  29. pmbus.hpp
  30. README.md
  31. types.hpp
  32. utility.cpp
  33. utility.hpp
README.md

Overview

This repository contains applications for configuring and monitoring devices that deliver power to the system.

  • cold-redundancy: Application that makes power supplies work in Cold Redundancy mode and rotates them at intervals.
  • phosphor-power-sequencer: Applications for configuring and monitoring power sequencer and related devices that support JSON-driven configuration.
  • phosphor-power-supply: Next generation power supply monitoring application.
  • phosphor-regulators: JSON-driven application that configures and monitors voltage regulators.
  • power-sequencer: A power sequencer monitoring application.
  • power-supply: Original power supply monitoring application.
  • tools/power-utils: Power supply utilities.

Build

To build all applications in this repository:

  meson build
  ninja -C build

To clean the repository and remove all build output:

  rm -rf build

You can specify meson options to customize the build process. For example, you can specify:

  • Which applications to build and install.
  • Application-specific configuration data, such as power sequencer type.
  • Whether to build tests.

Power Supply Monitor and Util JSON config

Several applications in this repository require a PSU JSON config to run. The JSON config file provides information for:

  • Where to access the pmbus attributes
  • Which attribute file in pmbus maps to which property and interface in D-Bus
  • Which kernel device directory is used on which PSU

There is an example psu.json to describe the necessary configurations.

  • inventoryPMBusAccessType defines the pmbus access type, which tells the service which sysfs type to use to read the attributes. The possible values are:
    • Base: The base dir, e.g. /sys/bus/i2c/devices/3-0069/
    • Hwmon: The hwmon dir, e.g. /sys/bus/i2c/devices/3-0069/hwmon/hwmonX/
    • Debug: The pmbus debug dir, e.g. /sys/kernel/debug/pmbus/hwmonX/
    • DeviceDebug: The device debug dir, e.g. '/sys/kernel/debug/./`
    • HwmonDeviceDebug: The hwmon device debug dir, e.g. /sys/kernel/debug/pmbus/hwmonX/cffps1/
  • fruConfigs defines the mapping between the attribute file and the FRU inventory interface and property. The configuration example below indicates that the service will read part_number attribute file from a directory specified by the above pmbus access type, and assign to PartNumber property in xyz.openbmc_project.Inventory.Decorator.Asset interface.
      "fruConfigs": [
    {
      "propertyName": "PartNumber",
      "fileName": "part_number",
      "interface": "xyz.openbmc_project.Inventory.Decorator.Asset"
    }
  ]
  • psuDevices defines the kernel device dir for each PSU in inventory. The configuration example below indicates that powersupply0's device is located in /sys/bus/i2c/devices/3-0069.
      "psuDevices": {
    "/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply0" : "/sys/bus/i2c/devices/3-0069",
  }