Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-power / 9666ddf6be93fca44411d495077dfedb5fd6bcdc
commit9666ddf6be93fca44411d495077dfedb5fd6bcdc[log] [tgz]
authorBrandon Wyman <bjwyman@gmail.com>Wed Apr 27 21:53:14 2022 +0000
committerShawn McCarney <shawnmm@us.ibm.com>Mon May 02 21:44:49 2022 +0000
treeda927e4d66f4555b5f49ab4f1b995a16567af00b
parentba6d96044e8b233a716050587f8f7d6263186690 [diff]
Do not run validation if input/UV fault

If any power supply has an input or VIN_UV fault, do not run the
configuration validation.

Two reasons to avoid running the configuration validation when an input
or VIN_UV fault is present:
  1) Avoid unnecessarily logging additional errors.
     - We know the voltage is wrong, it will log an error.
  2) Avoid logging the configuration invalid error that calls out the
  power supply.
     - That error would unnecessarily turn on the power supply fault LED.

Tested:
   Rainier 2S4U. System power off.
   Remove power from powersupply2 and powersupply3.
   Power system on.
   Without changes:
       Two 110015F0 PELs.
       One 110015F7 PEL.
       SAI LED on.
       powersupply2 Health critical, LED on.
       powersupply3 Health critical, LED off.
   With changes:
       Two 110015F0 PELs.
       SAI LED on.
       powersupply2 Health critical, LED off.
       powersupply3 Health critical, LED off.
   Resolve input power issue.
      Without Changes:
       powersupply2 Health critical, LED on.
       powersupply3 Health Okay.
      With Changes:
       powersupply2 Health Okay.
       powersupply3 Health Okay.
   Attempt resolve input power with wrong voltage:
      With Changes:
        powersupply0 called out in 110015F7. (wrong voltage)

Change-Id: Ie1628b0d9cf4dc25dc7bd2d4bc3f79779c54de97
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
1 file changed
tree: da927e4d66f4555b5f49ab4f1b995a16567af00b
  1. cold-redundancy/
  2. example/
  3. org/
  4. phosphor-power-sequencer/
  5. phosphor-power-supply/
  6. phosphor-regulators/
  7. power-sequencer/
  8. power-supply/
  9. services/
  10. test/
  11. tools/
  12. .clang-format
  13. .gitignore
  14. .shellcheck
  15. argument.hpp
  16. device.hpp
  17. device_monitor.hpp
  18. elog-errors.hpp
  19. file_descriptor.hpp
  20. gpio.cpp
  21. gpio.hpp
  22. LICENSE
  23. MAINTAINERS
  24. meson.build
  25. meson_options.txt
  26. names_values.hpp
  27. OWNERS
  28. pmbus.cpp
  29. pmbus.hpp
  30. README.md
  31. types.hpp
  32. utility.cpp
  33. utility.hpp
README.md

Overview

This repository contains applications for configuring and monitoring devices that deliver power to the system.

  • cold-redundancy: Application that makes power supplies work in Cold Redundancy mode and rotates them at intervals.
  • phosphor-power-sequencer: Applications for configuring and monitoring power sequencer and related devices that support JSON-driven configuration.
  • phosphor-power-supply: Next generation power supply monitoring application.
  • phosphor-regulators: JSON-driven application that configures and monitors voltage regulators.
  • power-sequencer: A power sequencer monitoring application.
  • power-supply: Original power supply monitoring application.
  • tools/power-utils: Power supply utilities.

Build

To build all applications in this repository:

  meson build
  ninja -C build

To clean the repository and remove all build output:

  rm -rf build

You can specify meson options to customize the build process. For example, you can specify:

  • Which applications to build and install.
  • Application-specific configuration data, such as power sequencer type.
  • Whether to build tests.

Power Supply Monitor and Util JSON config

Several applications in this repository require a PSU JSON config to run. The JSON config file provides information for:

  • Where to access the pmbus attributes
  • Which attribute file in pmbus maps to which property and interface in D-Bus
  • Which kernel device directory is used on which PSU

There is an example psu.json to describe the necessary configurations.

  • inventoryPMBusAccessType defines the pmbus access type, which tells the service which sysfs type to use to read the attributes. The possible values are:
    • Base: The base dir, e.g. /sys/bus/i2c/devices/3-0069/
    • Hwmon: The hwmon dir, e.g. /sys/bus/i2c/devices/3-0069/hwmon/hwmonX/
    • Debug: The pmbus debug dir, e.g. /sys/kernel/debug/pmbus/hwmonX/
    • DeviceDebug: The device debug dir, e.g. '/sys/kernel/debug/./`
    • HwmonDeviceDebug: The hwmon device debug dir, e.g. /sys/kernel/debug/pmbus/hwmonX/cffps1/
  • fruConfigs defines the mapping between the attribute file and the FRU inventory interface and property. The configuration example below indicates that the service will read part_number attribute file from a directory specified by the above pmbus access type, and assign to PartNumber property in xyz.openbmc_project.Inventory.Decorator.Asset interface.
      "fruConfigs": [
    {
      "propertyName": "PartNumber",
      "fileName": "part_number",
      "interface": "xyz.openbmc_project.Inventory.Decorator.Asset"
    }
  ]
  • psuDevices defines the kernel device dir for each PSU in inventory. The configuration example below indicates that powersupply0's device is located in /sys/bus/i2c/devices/3-0069.
      "psuDevices": {
    "/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply0" : "/sys/bus/i2c/devices/3-0069",
  }