pseq: Remove output voltage comparison to OV limit
The pgood isolation algorithm for the phosphor-power-sequencer
application is being enhanced to handle more error scenarios.
One major enhancement is the option to determine the pgood status of a
voltage rail by comparing the output voltage to a fault limit.
The original design was to compare the output voltage to both the
overvoltage limit (VOUT_OV_FAULT_LIMIT) and the undervoltage limit
(VOUT_UV_FAULT_LIMIT).
After discussions with subject matter experts, the design has been
changed to remove the comparison with the overvoltage limit. While this
is important status information, it is not necessarily indicative of a
pgood fault and could lead to false positives.
Change-Id: I664e4b16fcaf32900798c59aeb4e4ed48db964bf
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
diff --git a/phosphor-power-sequencer/src/config_file_parser.cpp b/phosphor-power-sequencer/src/config_file_parser.cpp
index 37c6b04..fe9c661 100644
--- a/phosphor-power-sequencer/src/config_file_parser.cpp
+++ b/phosphor-power-sequencer/src/config_file_parser.cpp
@@ -118,12 +118,12 @@
++propertyCount;
}
- // Optional compare_voltage_to_limits property
- bool compareVoltageToLimits{false};
- auto compareVoltageToLimitsIt = element.find("compare_voltage_to_limits");
- if (compareVoltageToLimitsIt != element.end())
+ // Optional compare_voltage_to_limit property
+ bool compareVoltageToLimit{false};
+ auto compareVoltageToLimitIt = element.find("compare_voltage_to_limit");
+ if (compareVoltageToLimitIt != element.end())
{
- compareVoltageToLimits = parseBoolean(*compareVoltageToLimitsIt);
+ compareVoltageToLimit = parseBoolean(*compareVoltageToLimitIt);
++propertyCount;
}
@@ -136,9 +136,9 @@
++propertyCount;
}
- // If check_status_vout or compare_voltage_to_limits property is true,
- // the page property is required; verify page was specified
- if ((checkStatusVout || compareVoltageToLimits) && !page.has_value())
+ // If check_status_vout or compare_voltage_to_limit property is true, the
+ // page property is required; verify page was specified
+ if ((checkStatusVout || compareVoltageToLimit) && !page.has_value())
{
throw std::invalid_argument{"Required property missing: page"};
}
@@ -147,8 +147,7 @@
verifyPropertyCount(element, propertyCount);
return std::make_unique<Rail>(name, presence, page, isPowerSupplyRail,
- checkStatusVout, compareVoltageToLimits,
- gpio);
+ checkStatusVout, compareVoltageToLimit, gpio);
}
std::vector<std::unique_ptr<Rail>> parseRailArray(const json& element)