commit a00e7300ed17684dcd46e5ab1bf95bb4bebd57ba
author Brandon Wyman <bjwyman@gmail.com> Tue Dec 21 23:28:29 2021 +0000
committer Brandon Wyman <bjwyman@gmail.com> Fri Jan 07 00:56:17 2022 +0000
tree ea3c92afb7b376e840f3ce54add875ccc0abe369
parent c2c8713192bc0d5dc375e0b8ac9a92b46299b340

psu-ng: Refactor IOUT_OC_FAULT detection

Split off code checking for IOUT_OC fault in STATUS_WORD to its own
function.

Change-Id: I4925149b0b1f9bce2400c83eb2808aeba0f7d1cc
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

phosphor-power-supply/power_supply.cpp

diff --git a/phosphor-power-supply/power_supply.cpp b/phosphor-power-supply/power_supply.cpp
index e31734b..9e58ff2 100644
--- a/phosphor-power-supply/power_supply.cpp
+++ b/phosphor-power-supply/power_supply.cpp
@@ -240,6 +240,23 @@
     }
 }
 
+void PowerSupply::analyzeIoutOCFault()
+{
+    if (statusWord & phosphor::pmbus::status_word::IOUT_OC_FAULT)
+    {
+        if (!ioutOCFault)
+        {
+            log<level::ERR>(fmt::format("IOUT fault: STATUS_WORD = {:#04x}, "
+                                        "STATUS_MFR_SPECIFIC = {:#02x}, "
+                                        "STATUS_IOUT = {:#02x}",
+                                        statusWord, statusMFR, statusIout)
+                                .c_str());
+        }
+
+        ioutOCFault = true;
+    }
+}
+
 void PowerSupply::analyzeTemperatureFault()
 {
     if (statusWord & phosphor::pmbus::status_word::TEMPERATURE_FAULT_WARN)
@@ -356,20 +373,7 @@
 
                 analyzeVoutOVFault();
 
-                if (statusWord & status_word::IOUT_OC_FAULT)
-                {
-                    if (!ioutOCFault)
-                    {
-                        log<level::ERR>(
-                            fmt::format("IOUT fault: STATUS_WORD = {:#04x}, "
-                                        "STATUS_MFR_SPECIFIC = {:#02x}, "
-                                        "STATUS_IOUT = {:#02x}",
-                                        statusWord, statusMFR, statusIout)
-                                .c_str());
-                    }
-
-                    ioutOCFault = true;
-                }
+                analyzeIoutOCFault();
 
                 if ((statusWord & status_word::VOUT_FAULT) &&
                     !(statusWord & status_word::VOUT_OV_FAULT))