commit ad70824cd6631a45809890369e33d46ed28ff206
author Brandon Wyman <bjwyman@gmail.com> Fri Jan 19 17:28:35 2018 -0600
committer Matt Spinler <spinler@us.ibm.com> Thu Feb 08 15:41:51 2018 +0000
tree c244ca0c31ff13f9c2802f801c778ebc8bc8cd25
parent c87eb82634729de26ab96a71dfb1338caf58829a

Only log input fault error when power is on

If the system power is on and a INPUT or VIN_UV fault is detected, log
an error with the appropriate metadata. If the power is off, just put an
informational message in the journal.

Resolves: openbmc/openbmc#2771

Change-Id: I1e30177e9f1f4d44a8b9cc1af9ef064d3eb37be4
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

power-supply/power_supply.cpp

diff --git a/power-supply/power_supply.cpp b/power-supply/power_supply.cpp
index 3d7673c..0c42ca0 100644
--- a/power-supply/power_supply.cpp
+++ b/power-supply/power_supply.cpp
@@ -293,6 +293,12 @@
         ((statusWord & status_word::INPUT_FAULT_WARN) ||
          (statusWord & status_word::VIN_UV_FAULT)))
     {
+        if (inputFault == 0)
+        {
+            log<level::INFO>("INPUT or VIN_UV fault",
+                             entry("STATUS_WORD=0x%04X", statusWord));
+        }
+
         inputFault++;
     }
     else
@@ -324,17 +330,22 @@
 
     if (!faultFound && (inputFault >= FAULT_COUNT))
     {
-        util::NamesValues nv;
-        nv.add("STATUS_WORD", statusWord);
-        captureCmd(nv, STATUS_INPUT, Type::Debug);
+        // If the power is on, report the fault in an error log entry.
+        if (powerOn)
+        {
+            util::NamesValues nv;
+            nv.add("STATUS_WORD", statusWord);
+            captureCmd(nv, STATUS_INPUT, Type::Debug);
 
-        using metadata = org::open_power::Witherspoon::Fault::
-                PowerSupplyInputFault;
+            using metadata = org::open_power::Witherspoon::Fault::
+                    PowerSupplyInputFault;
 
-        report<PowerSupplyInputFault>(
-                metadata::RAW_STATUS(nv.get().c_str()),
-                metadata::CALLOUT_INVENTORY_PATH(inventoryPath.c_str()));
-        faultFound = true;
+            report<PowerSupplyInputFault>(
+                    metadata::RAW_STATUS(nv.get().c_str()),
+                    metadata::CALLOUT_INVENTORY_PATH(inventoryPath.c_str()));
+
+            faultFound = true;
+        }
     }
 
 }