commit b9cf0d2b827b430b0ec24429ef6b9291a27f9ead
author George Liu <liuxiwei@inspur.com> Tue Feb 28 10:32:42 2023 +0800
committer George Liu <liuxiwei@inspur.com> Thu Mar 09 09:01:08 2023 +0800
tree c6eaa2222d2cb659f04196cb44daf22b446da31e
parent 7f6921e5cd03b1eabeca6bedbdc8d6b28616634f

tools: Fix some warnings by cppcheck

Warning message:
tools/i2c/i2c.hpp:30:9: performance: Variable 'busStr' is assigned in
constructor body. Consider performing initialization in
initialization list. [useInitializationList]
        busStr = "/dev/i2c-" + std::to_string(busId);
        ^

tools/power-utils/updater.cpp:213:18: style: Local variable 'devPath'
shadows outer variable [shadowVariable]
            auto devPath = internal::getDevicePath(p);
                 ^
tools/power-utils/updater.hpp:108:17: note: Shadowed declaration
    std::string devPath;
                ^
tools/power-utils/updater.cpp:213:18: note: Shadow variable
            auto devPath = internal::getDevicePath(p);
                 ^

Tested: Verify that there are no such warnings in local CI.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ibc7536345ee40579256c398646ad00a05b686ab3

tools/i2c/i2c.hpp

diff --git a/tools/i2c/i2c.hpp b/tools/i2c/i2c.hpp
index 23acdbc..5a01ebf 100644
--- a/tools/i2c/i2c.hpp
+++ b/tools/i2c/i2c.hpp
@@ -25,9 +25,9 @@
                        InitialState initialState = InitialState::OPEN,
                        int maxRetries = 0) :
         busId(busId),
-        devAddr(devAddr), maxRetries(maxRetries)
+        devAddr(devAddr), maxRetries(maxRetries),
+        busStr("/dev/i2c-" + std::to_string(busId))
     {
-        busStr = "/dev/i2c-" + std::to_string(busId);
         if (initialState == InitialState::OPEN)
         {
             open();