fix pseq-monitor and chassis power off race cond
Downstream testing recently found an issue where chassis power would be
removed before the pseq-monitor had stopped. This caused the
pseq-monitor to log errors.
Reviewing the systemd Conflicts documentation out at
https://www.freedesktop.org/software/systemd/man/systemd.unit.html
highlights some special caveats with the Conflicts statement.
Mainly that ordering is not guaranteed without an After or Before
clause. Testing also showed that when it comes to a service vs. target
conflicts, the most systemd will do is guarantee the conflicting service
is stopped before the target completes.
Give the above constraints, move the pseq-monitor Conflicts to the
obmc-power-stop-pre@.target and add an After clause. The
obmc-power-stop-pre@.target is the target which runs prior to power
being removed from the chassis.
Tested:
- Verified pseq monitor services consistently stop before the power is
removed from the chassis.
Change-Id: Ic73efc6281c3c422e0b483d4c24cb92228fd5875
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
diff --git a/services/pseq-monitor.service b/services/pseq-monitor.service
index 8ce3b37..aa7524e 100644
--- a/services/pseq-monitor.service
+++ b/services/pseq-monitor.service
@@ -3,7 +3,8 @@
Wants=obmc-host-start-pre@0.target
Before=obmc-host-start-pre@0.target
After=obmc-power-on@0.target
-Conflicts=obmc-chassis-poweroff@0.target
+Conflicts=obmc-power-stop-pre@0.target
+After=obmc-power-stop-pre@0.target
[Service]
ExecStart=/usr/bin/env pseq-monitor -a runtime-monitor -i 500