commit c220343cc9808c2ae57cb28390aa3973b7500141
author Brandon Wyman <bjwyman@gmail.com> Tue Dec 21 23:09:48 2021 +0000
committer Brandon Wyman <bjwyman@gmail.com> Fri Jan 07 00:56:17 2022 +0000
tree 0ea460ce00c09b3a84d7f2500e6eb8cac3995972
parent 52cb3f2898a8eb167b970d11dc8cc6056bb25f9b

psu-ng: Refactor CML fault detection

Split off CML fault checking of STATUS_WORD into its own function.

Change-Id: I845fe0dbcc86f085057bd5128303dde04cd9057f
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

phosphor-power-supply/power_supply.cpp

diff --git a/phosphor-power-supply/power_supply.cpp b/phosphor-power-supply/power_supply.cpp
index b5eeb2f..13d11f7 100644
--- a/phosphor-power-supply/power_supply.cpp
+++ b/phosphor-power-supply/power_supply.cpp
@@ -189,6 +189,22 @@
     }
 }
 
+void PowerSupply::analyzeCMLFault()
+{
+    if (statusWord & phosphor::pmbus::status_word::CML_FAULT)
+    {
+        if (!cmlFault)
+        {
+            log<level::ERR>(fmt::format("CML fault: STATUS_WORD = {:#04x}, "
+                                        "STATUS_CML = {:#02x}",
+                                        statusWord, statusCML)
+                                .c_str());
+        }
+
+        cmlFault = true;
+    }
+}
+
 void PowerSupply::analyzeTemperatureFault()
 {
     if (statusWord & phosphor::pmbus::status_word::TEMPERATURE_FAULT_WARN)
@@ -298,19 +314,8 @@
                 statusFans12 = pmbusIntf->read(STATUS_FANS_1_2, Type::Debug);
                 statusTemperature =
                     pmbusIntf->read(STATUS_TEMPERATURE, Type::Debug);
-                if (statusWord & status_word::CML_FAULT)
-                {
-                    if (!cmlFault)
-                    {
-                        log<level::ERR>(
-                            fmt::format("CML fault: STATUS_WORD = {:#04x}, "
-                                        "STATUS_CML = {:#02x}",
-                                        statusWord, statusCML)
-                                .c_str());
-                    }
 
-                    cmlFault = true;
-                }
+                analyzeCMLFault();
 
                 if (statusWord & status_word::INPUT_FAULT_WARN)
                 {