commit d3e4dad309c0cf9303128be7d7f831bdf5f13e26
author Matt Spinler <spinler@us.ibm.com> Thu Oct 25 16:17:32 2018 -0500
committer Matt Spinler <spinler@us.ibm.com> Thu Oct 25 16:20:18 2018 -0500
tree c5e8e19d29d03daa3ab54e93b141929979f96c6d
parent f0f02b9ae21ece3d691c1bbea348b468787ed2ff

Remove unused is_method_error calls

According to
https://lists.ozlabs.org/pipermail/openbmc/2018-October/013696.html,
message::is_method_error() will never fail and it doesn't need to
be called anymore.

Change-Id: I3199c201a3d89c90ff61484018846d9edca48eec
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

power-supply/power_supply.cpp

diff --git a/power-supply/power_supply.cpp b/power-supply/power_supply.cpp
index 5988ea9..1c069d1 100644
--- a/power-supply/power_supply.cpp
+++ b/power-supply/power_supply.cpp
@@ -716,12 +716,6 @@
         method.append(std::move(object));
 
         auto reply = bus.call(method);
-        if (reply.is_method_error())
-        {
-            log<level::ERR>(
-                "Unable to update power supply inventory properties",
-                entry("PATH=%s", path.c_str()));
-        }
 
         // TODO: openbmc/openbmc#2756
         // Calling Notify() with an enumerated property crashes inventory

utility.cpp

diff --git a/utility.cpp b/utility.cpp
index e9918bb..836bd33 100644
--- a/utility.cpp
+++ b/utility.cpp
@@ -38,15 +38,6 @@
     method.append(std::vector<std::string>({interface}));
 
     auto reply = bus.call(method);
-    if (reply.is_method_error())
-    {
-        log<level::ERR>("Error in mapper call to get service name",
-                        entry("PATH=%s", path.c_str()),
-                        entry("INTERFACE=%s", interface.c_str()));
-
-        // TODO openbmc/openbmc#851 - Once available, throw returned error
-        throw std::runtime_error("Error in mapper call to get service name");
-    }
 
     std::map<std::string, std::vector<std::string>> response;
     reply.read(response);

utility.hpp

diff --git a/utility.hpp b/utility.hpp
index ac7ef1f..0f008e3 100644
--- a/utility.hpp
+++ b/utility.hpp
@@ -54,16 +54,6 @@
     method.append(interface, propertyName);
 
     auto reply = bus.call(method);
-    if (reply.is_method_error())
-    {
-        using namespace phosphor::logging;
-        log<level::ERR>("Error in property get call",
-                        entry("PATH=%s", path.c_str()),
-                        entry("PROPERTY=%s", propertyName.c_str()));
-
-        // TODO openbmc/openbmc#851 - Once available, throw returned error
-        throw std::runtime_error("Error in property get call");
-    }
 
     reply.read(property);
     value = sdbusplus::message::variant_ns::get<T>(property);
@@ -92,17 +82,6 @@
     method.append(interface, propertyName, propertyValue);
 
     auto reply = bus.call(method);
-    if (reply.is_method_error())
-    {
-        using namespace phosphor::logging;
-        log<level::ERR>("Error in property set call",
-                        entry("SERVICE=%s", service.c_str()),
-                        entry("PATH=%s", path.c_str()),
-                        entry("PROPERTY=%s", propertyName.c_str()));
-
-        // TODO openbmc/openbmc#851 - Once available, throw returned error
-        throw std::runtime_error("Error in property set call");
-    }
 }
 
 /**