Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-power / e22e0c4b93db96ec8245f012059e9b9be602c544
commite22e0c4b93db96ec8245f012059e9b9be602c544[log] [tgz]
authorShawn McCarney <shawnmm@us.ibm.com>Tue Apr 07 18:41:46 2020 -0500
committerShawn McCarney <shawnmm@us.ibm.com>Wed Apr 08 17:41:59 2020 -0500
treed4a266a8c2722daffd71e8ead24c706aa4d95772
parentdb0b833cdd29f1c7d4939d795cb94c2f48a95ef3 [diff]
regulators: Fix IDMap testcases for duplicate IDs

A recent commit enhanced the IDMap class to detect duplicate IDs.

The corresponding testcases were missing an ADD_FAILURE() statement
covering the case where the expected exception was not thrown.

Fixed the testcases by adding the ADD_FAILURE() statements.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I5a88f446e4712e550e3e66dd2c359971e1f8a9b4
1 file changed
tree: d4a266a8c2722daffd71e8ead24c706aa4d95772
  1. cold-redundancy/
  2. example/
  3. org/
  4. phosphor-power-supply/
  5. phosphor-regulators/
  6. power-sequencer/
  7. power-supply/
  8. services/
  9. test/
  10. tools/
  11. .clang-format
  12. .gitignore
  13. argument.hpp
  14. device.hpp
  15. device_monitor.hpp
  16. elog-errors.hpp
  17. file.hpp
  18. gpio.cpp
  19. gpio.hpp
  20. LICENSE
  21. MAINTAINERS
  22. meson.build
  23. meson_options.txt
  24. names_values.hpp
  25. pmbus.cpp
  26. pmbus.hpp
  27. README.md
  28. types.hpp
  29. utility.cpp
  30. utility.hpp
README.md

Code for detecting and analyzing power faults on Witherspoon.

To Build

To build this package, do the following steps:

    1. meson build
    2. ninja -C build

To clean the repository again run `rm -rf build`.

Power Supply Monitor and Util JSON config

Several applications in this repository require a PSU JSON config to run. The JSON config file provides information for:

  • Where to access the pmbus attributes
  • Which attribute file in pmbus maps to which property and interface in D-Bus
  • Which kernel device directory is used on which PSU

There is an example psu.json to describe the necessary configurations.

  • inventoryPMBusAccessType defines the pmbus access type, which tells the service which sysfs type to use to read the attributes. The possible values are:
    • Base: The base dir, e.g. /sys/bus/i2c/devices/3-0069/
    • Hwmon: The hwmon dir, e.g. /sys/bus/i2c/devices/3-0069/hwmon/hwmonX/
    • Debug: The pmbus debug dir, e.g. /sys/kernel/debug/pmbus/hwmonX/
    • DeviceDebug: The device debug dir, e.g. '/sys/kernel/debug/./`
    • HwmonDeviceDebug: The hwmon device debug dir, e.g. /sys/kernel/debug/pmbus/hwmonX/cffps1/
  • fruConfigs defines the mapping between the attribute file and the FRU inventory interface and property. The configuration example below indicates that the service will read part_number attribute file from a directory specified by the above pmbus access type, and assign to PartNumber property in xyz.openbmc_project.Inventory.Decorator.Asset interface.
      "fruConfigs": [
    {
      "propertyName": "PartNumber",
      "fileName": "part_number",
      "interface": "xyz.openbmc_project.Inventory.Decorator.Asset"
    }
  ]
  • psuDevices defines the kernel device dir for each PSU in inventory. The configuration example below indicates that powersupply0's device is located in /sys/bus/i2c/devices/3-0069.
      "psuDevices": {
    "/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply0" : "/sys/bus/i2c/devices/3-0069",
  }