commit f087f4750c1e50e4db50c99d904d7c05f64fe4c8
author Brandon Wyman <bjwyman@gmail.com> Wed Dec 22 00:04:27 2021 +0000
committer Brandon Wyman <bjwyman@gmail.com> Fri Jan 07 00:56:17 2022 +0000
tree 8b1673ee65d5601c0f03bff60a00852e6b625214
parent d5d9a225221a15e149fde22722c2c8c25469186f

psu-ng: Refactor VIN_UV fault detection

Split off code checking for VIN_UV fault in STATUS_WORD to its own
function.

Change-Id: Ifd07b6958885ed19c7611e10e343d1a5f10ec684
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

phosphor-power-supply/power_supply.cpp

diff --git a/phosphor-power-supply/power_supply.cpp b/phosphor-power-supply/power_supply.cpp
index fbbcb14..d416c94 100644
--- a/phosphor-power-supply/power_supply.cpp
+++ b/phosphor-power-supply/power_supply.cpp
@@ -375,6 +375,23 @@
     }
 }
 
+void PowerSupply::analyzeVinUVFault()
+{
+    if (statusWord & phosphor::pmbus::status_word::VIN_UV_FAULT)
+    {
+        if (!vinUVFault)
+        {
+            log<level::ERR>(fmt::format("VIN_UV fault: STATUS_WORD = {:#04x}, "
+                                        "STATUS_MFR_SPECIFIC = {:#02x}, "
+                                        "STATUS_INPUT = {:#02x}",
+                                        statusWord, statusMFR, statusInput)
+                                .c_str());
+        }
+
+        vinUVFault = true;
+    }
+}
+
 void PowerSupply::analyze()
 {
     using namespace phosphor::pmbus;
@@ -422,20 +439,7 @@
 
                 analyzeMFRFault();
 
-                if (statusWord & status_word::VIN_UV_FAULT)
-                {
-                    if (!vinUVFault)
-                    {
-                        log<level::ERR>(
-                            fmt::format("VIN_UV fault: STATUS_WORD = {:#04x}, "
-                                        "STATUS_MFR_SPECIFIC = {:#02x}, "
-                                        "STATUS_INPUT = {:#02x}",
-                                        statusWord, statusMFR, statusInput)
-                                .c_str());
-                    }
-
-                    vinUVFault = true;
-                }
+                analyzeVinUVFault();
             }
             else
             {