Refactor: remove DeleteAll interface
There is no need for ItemUpdater to implement DeleteAll interface,
remove it.
Also make Activation::versionId private and provide a public
getVersionId() method;
Make ItemUpdater::erase() to pass const reference.
Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: Ifd6c61fc21b2967d6c83f1df7aaa3b2e94cae86c
diff --git a/src/item_updater.hpp b/src/item_updater.hpp
index c0a64fa..67f6e57 100644
--- a/src/item_updater.hpp
+++ b/src/item_updater.hpp
@@ -25,8 +25,8 @@
class Version;
using ItemUpdaterInherit = sdbusplus::server::object::object<
- sdbusplus::xyz::openbmc_project::Association::server::Definitions,
- sdbusplus::xyz::openbmc_project::Collection::server::DeleteAll>;
+ sdbusplus::xyz::openbmc_project::Association::server::Definitions>;
+
namespace MatchRules = sdbusplus::bus::match::rules;
/** @class ItemUpdater
@@ -57,12 +57,7 @@
*
* @param[in] versionId - Id of the version to delete
*/
- void erase(std::string versionId);
-
- /**
- * @brief Erases any non-active versions.
- */
- void deleteAll();
+ void erase(const std::string& versionId);
/** @brief Creates an active association to the
* newly active software image