commit 6f5342d0bdb2b2b8c52323219656f88794abf54f
author Konstantin Aladyshev <aladyshev22@gmail.com> Wed Apr 19 09:23:11 2023 +0000
committer Konstantin Aladyshev <aladyshev22@gmail.com> Mon May 15 14:14:16 2023 +0000
tree d28264f7d26755b82a38b3ebd961a3819f080eea
parent 3f23da94c959b1e46aae8931d59863211bcd3ee1

Make SEL logger messages more informative

Currently log entries are created using the "report" function from the
phosphor-logging repo. The problem is that function uses YAML file
"SEL.errors.yaml" for the message content. This leaves no space for the
message customization. And because of that webui displays all SEL
messages with a description
"xyz.openbmc_project.Logging.SEL.Error.Created" which is not very
informative.
To correct that switch to using "xyz.openbmc_project.Logging.Create"
function directly and create message content dynamically from all of
the incoming parameters.

Example of a SEL message description in webui:
- Before: "xyz.openbmc_project.Logging.SEL.Error.Created"
- After: "SEL Entry from System: RecordType=2, GeneratorID=65,
EventDir=1, EventData=01"

Change-Id: Iba17bd4c1834dd804c2eec04879fe226de2dfef7
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

include/threshold_alarm_event_monitor.hpp

diff --git a/include/threshold_alarm_event_monitor.hpp b/include/threshold_alarm_event_monitor.hpp
index bdfd3a9..0010d4b 100644
--- a/include/threshold_alarm_event_monitor.hpp
+++ b/include/threshold_alarm_event_monitor.hpp
@@ -238,7 +238,7 @@
                            ". Reading=" + std::to_string(assertValue) +
                            " Threshold=" + std::to_string(thresholdVal) + ".");
 
-    selAddSystemRecord(journalMsg, std::string(msg.get_path()), eventData,
+    selAddSystemRecord(conn, journalMsg, std::string(msg.get_path()), eventData,
                        assert, selBMCGenID, "REDFISH_MESSAGE_ID=%s",
                        redfishMessageID.c_str(),
                        "REDFISH_MESSAGE_ARGS=%.*s,%f,%f", sensorName.length(),