fix cppcheck warnings
- Single parameter constructor was not marked 'explicit'.
- Member variable was not initialized in the constructor init.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I42c35e8300ca6670155840ddf47f61a7b93d5b42
diff --git a/settings_manager.mako.hpp b/settings_manager.mako.hpp
index c344641..13bdc93 100644
--- a/settings_manager.mako.hpp
+++ b/settings_manager.mako.hpp
@@ -272,10 +272,8 @@
/** @brief Constructor to put settings objects on to the bus.
* @param[in] bus - Bus to attach to.
*/
- Manager(sdbusplus::bus::bus& bus)
- {
- fs::path path{};
- settings =
+ explicit Manager(sdbusplus::bus::bus& bus) :
+ settings(
std::make_tuple(
% for index, path in enumerate(objects):
<% type = get_setting_type(path) + "::Impl" %>\
@@ -284,10 +282,14 @@
% if index < len(settingsDict) - 1:
"${path}"),
% else:
- "${path}"));
+ "${path}")
% endif
% endfor
+ )
+ )
+ {
+ fs::path path{};
% for index, path in enumerate(objects):
path = fs::path(SETTINGS_PERSIST_PATH) / "${path}";
path += persistent::fileSuffix;