tree f4322f9fbc7f6353cd8bcc7e66f42683872b2dab
parent df871e9d389f99846ed16099dd94c6dc37d17e10
author Asmitha Karunanithi <asmitk01@in.ibm.com> 1622458368 -0500
committer Asmitha Karunanithi <asmitk01@in.ibm.com> 1623140196 +0000

Add validation of IP address

With the current implementation, when configuring a wrong ip,
there no error thrown, instead that ip address is being configured.

POST -d '{"data":["10.10.10",162]}' https://${bmc}/xyz/openbmc_project/network/snmp/manager/action/Client
{
  "data": "/xyz/openbmc_project/network/snmp/manager/27",
  "message": "200 OK",
  "status": "ok"
}

This commit adds the validation of the ip address during
the configuration.

Tested-By:

Failure case:
POST -d '{"data":["10.10.10",162]}' https://${bmc}/xyz/openbmc_project/network/snmp/manager/action/Client
{
  "data": {
    "description": "xyz.openbmc_project.Common.Error.InvalidArgument"
  },
  "message": "Invalid argument was given.",
  "status": "error"
}

Few more cases that are tested:
"10.10.10.10.10"
"10.10.10.100000"
"10.10.10.bb"
"10.10.10.10.bb"
"10.10.bb.aa"

Success case:
POST -d '{"data":["10.10.10.101",162]}' https://${bmc}/xyz/openbmc_project/network/snmp/manager/action/Client
{
  "data": "/xyz/openbmc_project/network/snmp/manager/1",
  "message": "200 OK",
  "status": "ok"
}

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: Ia08e6eeaa70e3ce45eb055cf927901b36bc4f845