commit b9b4c7dbe36b52288a8882e95868925b76bcaf8c
author Patrick Williams <patrick@stwcx.xyz> Tue Apr 05 16:20:37 2022 -0500
committer Patrick Williams <patrick@stwcx.xyz> Tue Apr 05 16:20:37 2022 -0500
tree 104765ccc81bdb3a3111fc4b0d9e8a5ddd8e0079
parent 34d129a95281dd93ebf88f901895bc89c32b0bcd

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications.  Map all `true` occurrences to
`action::defer_emit`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I12bac733597177ec85336a204b081779fe6ce19e

snmp_client.cpp

diff --git a/snmp_client.cpp b/snmp_client.cpp
index a636971..c084ea4 100644
--- a/snmp_client.cpp
+++ b/snmp_client.cpp
@@ -12,7 +12,7 @@
 
 Client::Client(sdbusplus::bus::bus& bus, const char* objPath,
                ConfManager& parent, const std::string& address, uint16_t port) :
-    Ifaces(bus, objPath, true),
+    Ifaces(bus, objPath, Ifaces::action::defer_emit),
     id(std::stol(std::filesystem::path(objPath).filename())), parent(parent)
 {
     this->address(address);

snmp_client.hpp

diff --git a/snmp_client.hpp b/snmp_client.hpp
index bd3ab8e..d6206ff 100644
--- a/snmp_client.hpp
+++ b/snmp_client.hpp
@@ -54,7 +54,7 @@
      *  @param[in] parent - Parent D-bus Object.
      */
     Client(sdbusplus::bus::bus& bus, const char* objPath, ConfManager& parent) :
-        Ifaces(bus, objPath, true),
+        Ifaces(bus, objPath, Ifaces::action::defer_emit),
         id(std::stol(std::filesystem::path(objPath).filename())), parent(parent)
     {}
 

snmp_conf_manager.cpp

diff --git a/snmp_conf_manager.cpp b/snmp_conf_manager.cpp
index ed73daf..d77f8b7 100644
--- a/snmp_conf_manager.cpp
+++ b/snmp_conf_manager.cpp
@@ -25,7 +25,8 @@
 using Argument = xyz::openbmc_project::Common::InvalidArgument;
 
 ConfManager::ConfManager(sdbusplus::bus::bus& bus, const char* objPath) :
-    details::CreateIface(bus, objPath, true),
+    details::CreateIface(bus, objPath,
+                         details::CreateIface::action::defer_emit),
     dbusPersistentLocation(SNMP_CONF_PERSIST_PATH), bus(bus),
     objectPath(objPath)
 {}