commit e65b0a7035c5881718a5e444a73d2bd8d8f7213e
author George Liu <liuxiwei@inspur.com> Tue May 10 16:47:27 2022 +0800
committer George Liu <liuxiwei@inspur.com> Wed May 11 11:19:43 2022 +0800
tree 36732e68091b591a6e0e53f0fd8751920fd1ff1e
parent 4caedfbbaf8d28e2fffed5a6691fc41b0b4839d4

Handle D-Bus exceptions

Remove the usage of is_method_error()[1]
Also, add try-catch to handle D-Bus exceptions around mapper call.

[1]https://gerrit.openbmc-project.xyz/c/openbmc/sdbusplus/+/14010

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I042e86676950aa25d646ff597ac55500abe44ddf

snmp_util.cpp

diff --git a/snmp_util.cpp b/snmp_util.cpp
index 9f235d8..9516337 100644
--- a/snmp_util.cpp
+++ b/snmp_util.cpp
@@ -26,15 +26,17 @@
                                       "org.freedesktop.DBus.ObjectManager",
                                       "GetManagedObjects");
 
-    auto reply = bus.call(method);
-
-    if (reply.is_method_error())
+    try
+    {
+        auto reply = bus.call(method);
+        reply.read(interfaces);
+    }
+    catch (const sdbusplus::exception::exception& e)
     {
         lg2::error("Failed to get managed objects: {PATH}", "PATH", objPath);
         elog<InternalFailure>();
     }
 
-    reply.read(interfaces);
     return interfaces;
 }