bootblock: ensure no power operation on block
Systemd does not treat targets the same way it treats services. If you
start a target which has Wants/Requires, it will execute the services
associated with that target before the Wants/Requires for the target
have been fulfilled. The target will not set itself as complete until the
Wants/Requires is fulfilled but this causes a weird behavior currently.
For example, if ErrorBlocksTransition interface is present on D-Bus and
the obmc-chassis-poweron@.target is started, the system will fully power
on, but the chassis power state will continue to report as off. This is
because all services were launched under the target to power on the
system but because the target does not complete, the BMC still reports
the chassis power as not being on.
The solution is to move the bootblock dependencies from target
responsible for starting all of the services to the synchronization
target that services utilize to order their execution.
Putting the bootblock dependencies in the obmc-power-start-pre@.target
ensure no power on services will be run.
Tested:
- Ensured a bootblock now stops the system from powering on
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I78b6bff86a1e28bbedb6919724eeb5ee0b2a9a25
diff --git a/target_files/obmc-power-start-pre@.target b/target_files/obmc-power-start-pre@.target
index 9fef7c0..eb1c164 100644
--- a/target_files/obmc-power-start-pre@.target
+++ b/target_files/obmc-power-start-pre@.target
@@ -2,5 +2,9 @@
Description=Power%i On (Pre)
After=multi-user.target
Conflicts=obmc-chassis-poweroff@%i.target
+Wants=mapper-subtree-remove@-xyz-openbmc\x5fproject-software\x3Axyz.openbmc_project.Software.ActivationBlocksTransition.service
+After=mapper-subtree-remove@-xyz-openbmc\x5fproject-software\x3Axyz.openbmc_project.Software.ActivationBlocksTransition.service
+Wants=mapper-subtree-remove@-xyz-openbmc\x5fproject-logging\x3Axyz.openbmc_project.Logging.ErrorBlocksTransition.service
+After=mapper-subtree-remove@-xyz-openbmc\x5fproject-logging\x3Axyz.openbmc_project.Logging.ErrorBlocksTransition.service
RefuseManualStart=yes
RefuseManualStop=yes