tree b17aad89ec2896c6ca48842ee77182954b883d0c
parent 744fe62770dc797f77e9570925a02f1b3be3516e
author NodeMan97 <corey.hardesty@icloud.com> 1658323896 -0500
committer Andrew Geissler <andrew@geissonator.com> 1659010961 +0000

Utilization of power restore delay for APR

There was an issue where APR would start too early in the boot
process causing conflicts between the BMC and host firmware on
the i2c buses. Waiting to run APR ensures the BMC reaches a
READY state and that the vpd collection has completed.
This commit adds a delay based off of the value of
'PowerRestoreDelay' a Dbus property hosted by the RestorePolicy
interface. The system owners may override this value which is
initially defaulted to 0 via an override in their meta layer.

Tested:
      - Ran an AC cycle of the system and restarted phosphor-discover-
        system-state@0.service.

      - Ensure that the bmc reboot was delayed by the value
        specified by PowerRestoreDelay.

      - Verified through on real hardware. Simulation environment
        has system noise that create unpredictable delay results
        with delays over 15 seconds. The delays in simulation always
        adhere to the property, but take additional time to boot.

      - PowerRestoreDelay at 30 seconds (ran 5 separate times)
systemctl stop phosphor-discover-system-state@0.service

Jul 22 17:47:23 p10bmc phosphor-discover-system-state[2224]:
 power_policy=Restore, powering host on (30s delay)

Jul 22 17:47:53 p10bmc systemd[1]: Finished Reboot If Enabled

5/5 tests were delayed exactly 30 seconds.


      - PowerRestoreDelay at 100 seconds

Jul 22 17:52:45 p10bmc phosphor-discover-system-state[2224]:
 power_policy=Restore, powering host on (100s delay)

Jul 22 17:54:25 p10bmc systemd[1]: Finished Reboot If Enabled.

1/1 test(s) were delayed exactly 100 seconds.


     - PowerRestoreDelay at 0 seconds

Jul 22 18:02:51 p10bmc phosphor-discover-system-state[2271]:
 power_policy=Restore, powering host on (30s delay)

Jul 22 18:02:51 p10bmc systemd[1]: Finished Reboot If Enabled.


Signed-off-by: Corey Hardesty <corey.hardesty@icloud.com>
Change-Id: I69f7f9f3a9e638defcbee2bbb8dda6d9c4b7f0ae