clang-tidy: Enable readability-implicit-bool-conversion check
This check can be used to find implicit conversions between
built-in types and booleans.
the following conversion types are checked:
- integer expression/literal to boolean
- floating expression/literal to boolean
- pointer/pointer to member/nullptr/NULL to boolean
- boolean expression/literal to integer
- boolean expression/literal to floating
Change-Id: Ifb5d5f402342a2d3cca8378c6549ede3e56e3f38
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>
diff --git a/.clang-tidy b/.clang-tidy
index af74e06..d6d2a4c 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -248,6 +248,7 @@
readability-deleted-default,
readability-function-size,
readability-identifier-naming,
+readability-implicit-bool-conversion,
readability-isolate-declaration,
readability-make-member-function-const,
readability-misleading-indentation,
diff --git a/scheduled_host_transition.hpp b/scheduled_host_transition.hpp
index 5582bf6..82e0731 100644
--- a/scheduled_host_transition.hpp
+++ b/scheduled_host_transition.hpp
@@ -107,7 +107,7 @@
/** @brief The deleter of sd_event_source */
std::function<void(sd_event_source*)> sdEventSourceDeleter =
[](sd_event_source* p) {
- if (p)
+ if (p != nullptr)
{
sd_event_source_unref(p);
}