commit 66aacdc48c4a99884850e627261f26197e2e9445
author Andrew Geissler <geissonator@yahoo.com> Wed May 11 08:31:47 2022 -0400
committer Andrew Geissler <andrew@geissonator.com> Wed May 18 01:06:40 2022 +0000
tree c41d82d845b1ced564c87a4f2b03c7797a80c112
parent 0e044c483f1f89b9eaad0112f062f1be544c189e

ensure power status is always correct

There's a slight bug here in that anytime determineStatusOfPower() is
called, the PowerStatus was set to Good for a period of time. This can
cause confusion on clients monitoring the property. Instead of
defaulting it to good, set it after the true status is known.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: If48eb5bd1c2bd94d51d12aff54a186aba295b179

chassis_state_manager.hpp

diff --git a/chassis_state_manager.hpp b/chassis_state_manager.hpp
index e82a4cd..82ad2d1 100644
--- a/chassis_state_manager.hpp
+++ b/chassis_state_manager.hpp
@@ -100,13 +100,17 @@
 
     /** @brief Determine status of power provided by an Uninterruptible Power
      *         Supply into the system
+     *
+     *  @return True if UPS power is good, false otherwise
      */
-    void determineStatusOfUPSPower();
+    bool determineStatusOfUPSPower();
 
     /** @brief Determine status of power provided by the power supply units into
      *         the system
+     *
+     *  @return True if PSU power is good, false otherwise
      */
-    void determineStatusOfPSUPower();
+    bool determineStatusOfPSUPower();
 
     /**
      * @brief subscribe to the systemd signals