bmc-quiesce: ensure bmc stays in quiesce
Removed redundant signal changes when bmc is in quiesced state.
The system state signal should be reset in order to avoid any
potential changes.
Tested:
-Ran in a Docker container using the build unit-test script.
-Built and tested in simics. After setting the bmc's state
to quiesced I then attempted to start the bmc to change it's
state. I verified the intended functionality with obmcutil
and received the expected output.
root@p10bmc:~# systemctl start obmc-bmc-service-quiesce@0.target
root@p10bmc:~# systemctl start multi-user.target
root@p10bmc:~# obmcutil state
CurrentBMCState: xyz.openbmc_project.State.BMC.BMCState.Quiesced
Signed-off-by: Corey Hardesty <corey.hardesty@icloud.com>
Change-Id: I358a42b8da06b334030908c18842aef60fa3c5c2
diff --git a/bmc_state_manager.cpp b/bmc_state_manager.cpp
index 37597f8..a921fda 100644
--- a/bmc_state_manager.cpp
+++ b/bmc_state_manager.cpp
@@ -205,7 +205,6 @@
try
{
this->bus.call(method);
- this->stateSignal.release();
}
catch (const sdbusplus::exception::exception& e)
{
@@ -213,7 +212,7 @@
}
// disable the system state change object as well
- stateSignal.reset();
+ this->stateSignal.reset();
return 0;
}