commit 9a286db223cecd88ecdcf29e6a1e713fdd1bf115
author Patrick Williams <patrick@stwcx.xyz> Wed Jan 17 06:29:47 2024 -0600
committer Patrick Williams <patrick@stwcx.xyz> Wed Jan 17 16:34:34 2024 -0600
tree f64118099d54783ec19f32127c53344f4596739c
parent 471208419db593ea8e343e29008e6ff136bc3160

reduce dbus string constants

There are a large number of dbus constants scattered throughout the
code that could/should be obtained from phosphor-dbus-interface values.
Perform minor refactoring to greatly reduce the number of string
constants.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie8700bc90611d21eee7160f4686bc978fe0a0eb4

scheduled_host_transition.cpp

diff --git a/scheduled_host_transition.cpp b/scheduled_host_transition.cpp
index c827807..28541f5 100644
--- a/scheduled_host_transition.cpp
+++ b/scheduled_host_transition.cpp
@@ -11,6 +11,7 @@
 #include <phosphor-logging/elog.hpp>
 #include <phosphor-logging/lg2.hpp>
 #include <xyz/openbmc_project/ScheduledTime/error.hpp>
+#include <xyz/openbmc_project/State/Host/error.hpp>
 
 #include <chrono>
 #include <filesystem>
@@ -208,12 +209,12 @@
         }
         catch (const sdbusplus::exception_t& e)
         {
+            using BMCNotReady = sdbusplus::error::xyz::openbmc_project::state::
+                host::BMCNotReady;
             // If error indicates BMC is not at Ready error then reschedule for
             // 60s later
             if ((e.name() != nullptr) &&
-                (e.name() ==
-                 std::string_view(
-                     "xyz.openbmc_project.State.Host.Error.BMCNotReady")))
+                (e.name() == std::string_view(BMCNotReady::errName)))
             {
                 warning(
                     "BMC is not at ready, reschedule transition request for 60s");