commit 9a286db223cecd88ecdcf29e6a1e713fdd1bf115
author Patrick Williams <patrick@stwcx.xyz> Wed Jan 17 06:29:47 2024 -0600
committer Patrick Williams <patrick@stwcx.xyz> Wed Jan 17 16:34:34 2024 -0600
tree f64118099d54783ec19f32127c53344f4596739c
parent 471208419db593ea8e343e29008e6ff136bc3160

reduce dbus string constants

There are a large number of dbus constants scattered throughout the
code that could/should be obtained from phosphor-dbus-interface values.
Perform minor refactoring to greatly reduce the number of string
constants.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie8700bc90611d21eee7160f4686bc978fe0a0eb4

secure_boot_check.cpp

diff --git a/secure_boot_check.cpp b/secure_boot_check.cpp
index c5f6dd8..ce3dfe0 100644
--- a/secure_boot_check.cpp
+++ b/secure_boot_check.cpp
@@ -3,6 +3,7 @@
 #include "utils.hpp"
 
 #include <phosphor-logging/lg2.hpp>
+#include <xyz/openbmc_project/Logging/Settings/client.hpp>
 
 #include <filesystem>
 #include <fstream>
@@ -11,6 +12,8 @@
 PHOSPHOR_LOG2_USING;
 
 constexpr auto PROPERTY_INTERFACE = "org.freedesktop.DBus.Properties";
+using LoggingSettings =
+    sdbusplus::client::xyz::openbmc_project::logging::Settings<>;
 
 // Check if the TPM measurement file exists and has a valid value.
 // If the TPM measurement is invalid, it logs an error message.
@@ -68,7 +71,7 @@
 {
     auto bus = sdbusplus::bus::new_default();
     std::string path = "/xyz/openbmc_project/logging/settings";
-    std::string interface = "xyz.openbmc_project.Logging.Settings";
+    std::string interface = LoggingSettings::interface;
     std::string propertyName = "QuiesceOnHwError";
     std::variant<bool> mfgModeEnabled;