tree 2c8ffd0d13519426d6ffc9ea174e45b782146b63
parent 8be7ec4510d7932dd9a8942cfa67cc05fe10866f
author Patrick Williams <patrick@stwcx.xyz> 1709331655 -0600
committer Patrick Williams <patrick@stwcx.xyz> 1710170205 -0500

remove 'flush' failure modes

The `flush` failure mode is impossible to use for a multi-host system.
If one of the services or targets fail on one host, it would cause the
pending operations for the other host to be flushed from the systemd
job queue.  This leaves the other hosts in an indeterminate state.

We need to use `fail` in order to allow jobs targeting other hosts to
continue operating.  This triggers the OnFailure for the target(s),
including ones which are pending awaiting dependencies.

As a result of this change, we may need to tweak some of the existing
services to add correct OnFailures.

Tested: Ran on a yosemite4 image in QEMU, which always fails part of
the boot sequence due to a missing PLDM-based satellite management
controller.  After a few host reboot attempts the system settles into a
stable state on all hosts.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2071219c9c139723785ba05bed18a6ff808ad565