commit f93c405fd2af186a36cdbbe763d51edd846a3f32
author Pavithra Barithaya <pavithra.b@ibm.com> Wed Apr 26 23:28:13 2023 -0500
committer Pavithra Barithaya <pavithra.b@ibm.com> Thu Apr 27 00:36:14 2023 -0500
tree 08f8ab7065f4f18803527e87f6601bd14e5f8f84
parent 506b366362fa8c75a0c351442b016f43472a2638

Enable modernize tidy checks on the repo

This commit enables the modernize clang-tidy
checks.

Change-Id: I586303ebc257c6e6e05489247bc75d227b328607
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
index 13fcacb..b0973f4 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -195,6 +195,29 @@
 clang-analyzer-valist.ValistBase,
 clang-analyzer-webkit.NoUncountedMemberChecker,
 clang-analyzer-webkit.RefCntblBaseVirtualDtor,
+modernize-avoid-bind,
+modernize-deprecated-headers,
+modernize-deprecated-ios-base-aliases,
+modernize-loop-convert,
+modernize-make-shared,
+modernize-make-unique,
+modernize-raw-string-literal,
+modernize-replace-auto-ptr,
+modernize-replace-random-shuffle,
+modernize-return-braced-init-list,
+modernize-shrink-to-fit,
+modernize-unary-static-assert,
+modernize-use-bool-literals,
+modernize-use-default-member-init,
+modernize-use-emplace,
+modernize-use-equals-default,
+modernize-use-equals-delete,
+modernize-use-noexcept,
+modernize-use-nullptr,
+modernize-use-override,
+modernize-use-transparent-functors,
+modernize-use-uncaught-exceptions,
+modernize-use-using,
 performance-faster-string-find,
 performance-for-range-copy,
 performance-implicit-conversion-in-loop,

bmc_epoch.hpp

diff --git a/bmc_epoch.hpp b/bmc_epoch.hpp
index fd5e3f4..e4047f0 100644
--- a/bmc_epoch.hpp
+++ b/bmc_epoch.hpp
@@ -32,7 +32,7 @@
         initialize();
     }
 
-    ~BmcEpoch();
+    ~BmcEpoch() override;
 
     /** @brief Notified on time mode changed */
     void onModeChanged(Mode mode) override;

manager.cpp

diff --git a/manager.cpp b/manager.cpp
index 36285ff..1aeaf4b 100644
--- a/manager.cpp
+++ b/manager.cpp
@@ -2,10 +2,10 @@
 
 #include "utils.hpp"
 
-#include <assert.h>
-
 #include <phosphor-logging/lg2.hpp>
 
+#include <cassert>
+
 namespace rules = sdbusplus::bus::match::rules;
 
 namespace // anonymous

property_change_listener.hpp

diff --git a/property_change_listener.hpp b/property_change_listener.hpp
index 6439d3e..e6fdcde 100644
--- a/property_change_listener.hpp
+++ b/property_change_listener.hpp
@@ -10,8 +10,7 @@
 class PropertyChangeListner
 {
   public:
-    virtual ~PropertyChangeListner()
-    {}
+    virtual ~PropertyChangeListner() = default;
 
     /** @brief Notified on time mode is changed */
     virtual void onModeChanged(Mode mode) = 0;

test/TestBmcEpoch.cpp

diff --git a/test/TestBmcEpoch.cpp b/test/TestBmcEpoch.cpp
index 8556d72..4d9c814 100644
--- a/test/TestBmcEpoch.cpp
+++ b/test/TestBmcEpoch.cpp
@@ -29,7 +29,7 @@
         bmcEpoch = std::make_unique<BmcEpoch>(bus, objpathBmc, manager);
     }
 
-    ~TestBmcEpoch()
+    ~TestBmcEpoch() override
     {
         bus.detach_event();
         sd_event_unref(event);