Remove priv-callback support
callback privilege must be used only with ipmi modem callback
connection. As OpenBMC doesn't support, and for other interfaces
this shouldn't allow the login, it has been decided to deprecate
the priv-callback permanently. Refer
https://gerrit.openbmc-project.xyz/#/c/openbmc/docs/+/26839/
Existing user with callback privilege will be automatically rolled
as No-Access priviliege user.
Tested
1. Verified that AllPrivileges property doesn't show priv-callback
2. Verified that redfish roles doesn't list callback
3. Verified if there are any user in this list already existing in the
system, and after update user was properly shown with No-Access privilege
Change-Id: I7b37d0134e3a335df121b35ad3cd4c88cc00536b
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
diff --git a/phosphor-ldap-config/ldap_config.hpp b/phosphor-ldap-config/ldap_config.hpp
index 220677c..20448dd 100644
--- a/phosphor-ldap-config/ldap_config.hpp
+++ b/phosphor-ldap-config/ldap_config.hpp
@@ -271,8 +271,11 @@
std::map<Id, std::unique_ptr<LDAPMapperEntry>> PrivilegeMapperList;
/** @brief available privileges container */
- std::set<std::string> privMgr = {"priv-admin", "priv-operator", "priv-user",
- "priv-callback"};
+ std::set<std::string> privMgr = {
+ "priv-admin",
+ "priv-operator",
+ "priv-user",
+ };
/** @brief React to InterfaceAdded signal
* @param[in] msg - sdbusplus message
diff --git a/phosphor-ldap-mapper/ldap_mapper_mgr.hpp b/phosphor-ldap-mapper/ldap_mapper_mgr.hpp
index ae8f6c9..7b3013d 100644
--- a/phosphor-ldap-mapper/ldap_mapper_mgr.hpp
+++ b/phosphor-ldap-mapper/ldap_mapper_mgr.hpp
@@ -98,8 +98,11 @@
std::string persistPath;
/** @brief available privileges container */
- std::set<std::string> privMgr = {"priv-admin", "priv-operator", "priv-user",
- "priv-callback"};
+ std::set<std::string> privMgr = {
+ "priv-admin",
+ "priv-operator",
+ "priv-user",
+ };
/** @brief Id of the last privilege mapper entry */
Id entryId = 0;
diff --git a/test/ldap_config_test.cpp b/test/ldap_config_test.cpp
index 635e1c0..5606af5 100644
--- a/test/ldap_config_test.cpp
+++ b/test/ldap_config_test.cpp
@@ -765,7 +765,6 @@
EXPECT_NO_THROW(entry->privilege("priv-operator"));
EXPECT_NO_THROW(entry->privilege("priv-user"));
- EXPECT_NO_THROW(entry->privilege("priv-callback"));
}
} // namespace ldap
diff --git a/test/ldap_mapper_test.cpp b/test/ldap_mapper_test.cpp
index 2b06cce..9853c85 100644
--- a/test/ldap_mapper_test.cpp
+++ b/test/ldap_mapper_test.cpp
@@ -133,7 +133,6 @@
EXPECT_NO_THROW(entry->privilege("priv-operator"));
EXPECT_NO_THROW(entry->privilege("priv-user"));
- EXPECT_NO_THROW(entry->privilege("priv-callback"));
}
TEST_F(TestSerialization, testInvalidPrivilege)
diff --git a/user_mgr.hpp b/user_mgr.hpp
index 80110e9..c008cea 100644
--- a/user_mgr.hpp
+++ b/user_mgr.hpp
@@ -188,8 +188,7 @@
/** @brief privilege manager container */
std::vector<std::string> privMgr = {"priv-admin", "priv-operator",
- "priv-user", "priv-callback",
- "priv-noaccess"};
+ "priv-user", "priv-noaccess"};
/** @brief groups manager container */
std::vector<std::string> groupsMgr = {"web", "redfish", "ipmi", "ssh"};