commit 75be4e68c7a599650a1800d7846182b06534bdca
author Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Fri Sep 18 15:59:06 2020 +0000
committer Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Mon Sep 21 23:17:14 2020 +0000
tree 315ca47ea87b4c7b6a6a8feca153f13475e58f35
parent 3a003e2f00a7fc52977219893de7d7cefac18e79

Treat pwd is not set if no entry in shadow for usr

There are situations (mostly manipulated), when user entry is present
in /etc/password, but not in /etc/shadow. Even though user can’t login
without proper entry in /etc/shadow, it is a valid user and password
update is only required

Tested:
1. Manually removed a user entry in /etc/shadow
2. Restarted phosphor-user-manager service
3. Made sure user is listed, and able to update the password through
   ipmitool set password command
4. Queried the user entry again and confirmed PasswordExpired is
   returned as false.

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I818be9a63121448210a99c175005708788279963

user_mgr.cpp

diff --git a/user_mgr.cpp b/user_mgr.cpp
index d1f881e..0447fe7 100644
--- a/user_mgr.cpp
+++ b/user_mgr.cpp
@@ -763,9 +763,11 @@
     }
     else
     {
-        log<level::ERR>("User does not exist",
-                        entry("USER_NAME=%s", userName.c_str()));
-        elog<UserNameDoesNotExist>();
+        // User entry is missing in /etc/shadow, indicating no SHA password.
+        // Treat this as new user without password entry in /etc/shadow
+        // TODO: Add property to indicate user password was not set yet
+        // https://github.com/openbmc/phosphor-user-manager/issues/8
+        return false;
     }
 
     return false;