commit 8a11d998712b2da3bd0b9a18bdda22933d665d29
author Nan Zhou <nanzhoumails@gmail.com> Tue Oct 25 00:07:06 2022 +0000
committer Nan Zhou <nanzhoumails@gmail.com> Tue Nov 08 17:41:32 2022 +0000
tree 2335b872bc92c759d842de966c51ea3610b1c251
parent e48085dbb9b2a9fc9d4c363e3843561c537c388c

user exist: simplify expression, add unit test

Simplified two boolean expression and added unit tests. The unit test
container has the root user by default and can be leveraged in the unit
test.

Tested: unit test passed.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: Ia335ad9e14e5cdeca5c260ef67f308f7197be349

user_mgr.cpp

diff --git a/user_mgr.cpp b/user_mgr.cpp
index 390981c..f2c500c 100644
--- a/user_mgr.cpp
+++ b/user_mgr.cpp
@@ -186,7 +186,7 @@
 
 void UserMgr::throwForUserDoesNotExist(const std::string& userName)
 {
-    if (isUserExist(userName) == false)
+    if (!isUserExist(userName))
     {
         log<level::ERR>("User does not exist",
                         entry("USER_NAME=%s", userName.c_str()));
@@ -196,7 +196,7 @@
 
 void UserMgr::throwForUserExists(const std::string& userName)
 {
-    if (isUserExist(userName) == true)
+    if (isUserExist(userName))
     {
         log<level::ERR>("User already exists",
                         entry("USER_NAME=%s", userName.c_str()));
@@ -1049,7 +1049,7 @@
 {
     UserInfoMap userInfo;
     // Check whether the given user is local user or not.
-    if (isUserExist(userName) == true)
+    if (isUserExist(userName))
     {
         const auto& user = usersList[userName];
         userInfo.emplace("UserPrivilege", user.get()->userPrivilege());