commit 8ad64b03b7f56907d6871086c82e6289d0ea7df1
author Chandramohan Harkude <chandramohan.harkude@gmail.com> Mon May 19 00:57:52 2025 +0530
committer Chandra Harkude <chandramohan.harkude@gmail.com> Mon May 19 04:56:15 2025 +0000
tree 78f2f9e7dbb04e761bcefc57de2e7a4455280a88
parent c4183b84ba512735b5b32c88f81b77091b0fd5cd

Fix Clang 20 build issues

It is observed that with recent change of clang to 20 there are some CI
build issues found on phosphor-user-manager based on readability and
style. I fixed the same

Change-Id: Ief2a902b9970c628b26e908b8c784efe9e524bf6
Signed-off-by: Chandramohan Harkude <chandramohan.harkude@gmail.com>

phosphor-ldap-config/ldap_config.hpp

diff --git a/phosphor-ldap-config/ldap_config.hpp b/phosphor-ldap-config/ldap_config.hpp
index d3fa604..768cf5f 100644
--- a/phosphor-ldap-config/ldap_config.hpp
+++ b/phosphor-ldap-config/ldap_config.hpp
@@ -32,7 +32,7 @@
     sdbusplus::server::object_t<ConfigIface, EnableIface, MapperIface>;
 using ObjectPath = sdbusplus::message::object_path;
 
-namespace sdbusRule = sdbusplus::bus::match::rules;
+namespace sdbus_rule = sdbusplus::bus::match::rules;
 
 class ConfigMgr;
 class MockConfigMgr;

phosphor-ldap-config/ldap_mapper_entry.hpp

diff --git a/phosphor-ldap-config/ldap_mapper_entry.hpp b/phosphor-ldap-config/ldap_mapper_entry.hpp
index 93918b9..5d03793 100644
--- a/phosphor-ldap-config/ldap_mapper_entry.hpp
+++ b/phosphor-ldap-config/ldap_mapper_entry.hpp
@@ -10,7 +10,7 @@
 namespace ldap
 {
 
-namespace Base = sdbusplus::xyz::openbmc_project;
+namespace base = sdbusplus::xyz::openbmc_project;
 using Entry =
     sdbusplus::xyz::openbmc_project::User::server::PrivilegeMapperEntry;
 using Delete = sdbusplus::xyz::openbmc_project::Object::server::Delete;

users.hpp

diff --git a/users.hpp b/users.hpp
index 6d66598..39c3ec3 100644
--- a/users.hpp
+++ b/users.hpp
@@ -27,11 +27,11 @@
 namespace user
 {
 
-namespace Base = sdbusplus::xyz::openbmc_project;
-using UsersIface = Base::User::server::Attributes;
+namespace base = sdbusplus::xyz::openbmc_project;
+using UsersIface = base::User::server::Attributes;
 
-using TOTPAuthenticatorIface = Base::User::server::TOTPAuthenticator;
-using DeleteIface = Base::Object::server::Delete;
+using TOTPAuthenticatorIface = base::User::server::TOTPAuthenticator;
+using DeleteIface = base::Object::server::Delete;
 using Interfaces = sdbusplus::server::object_t<UsersIface, DeleteIface,
                                                TOTPAuthenticatorIface>;
 using MultiFactorAuthType = sdbusplus::common::xyz::openbmc_project::user::