treewide: make code compie on clang
This patch fixed several minor issues that clang14 complains about.
1. clang-diagnostic-inconsistent-missing-override
2. clang-diagnostic-defaulted-function-deleted
3. clang-diagnostic-unused-const-variable
Tested:
1. it builds with clang14
2. tested on hardware, ldap config daemon and user manager daemon are
both good. Tested DBus APIs (e.g., create config) as well.
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: Idf8d0481fc05735b4b3d021f30aa44272f2369bf
diff --git a/phosphor-ldap-config/ldap_config.cpp b/phosphor-ldap-config/ldap_config.cpp
index c36820d..97e23ca 100644
--- a/phosphor-ldap-config/ldap_config.cpp
+++ b/phosphor-ldap-config/ldap_config.cpp
@@ -25,7 +25,6 @@
{
constexpr auto nslcdService = "nslcd.service";
-constexpr auto nscdService = "nscd.service";
constexpr auto LDAPscheme = "ldap";
constexpr auto LDAPSscheme = "ldaps";
constexpr auto certObjPath = "/xyz/openbmc_project/certs/client/ldap/1";
diff --git a/phosphor-ldap-config/ldap_config.hpp b/phosphor-ldap-config/ldap_config.hpp
index 94c0dd2..53a777f 100644
--- a/phosphor-ldap-config/ldap_config.hpp
+++ b/phosphor-ldap-config/ldap_config.hpp
@@ -55,8 +55,8 @@
~Config() = default;
Config(const Config&) = delete;
Config& operator=(const Config&) = delete;
- Config(Config&&) = default;
- Config& operator=(Config&&) = default;
+ Config(Config&&) = delete;
+ Config& operator=(Config&&) = delete;
/** @brief Constructor to put object onto bus at a D-Bus path.
* @param[in] bus - Bus to attach to.
diff --git a/phosphor-ldap-config/ldap_mapper_entry.hpp b/phosphor-ldap-config/ldap_mapper_entry.hpp
index 1c0c87f..93918b9 100644
--- a/phosphor-ldap-config/ldap_mapper_entry.hpp
+++ b/phosphor-ldap-config/ldap_mapper_entry.hpp
@@ -32,8 +32,8 @@
~LDAPMapperEntry() = default;
LDAPMapperEntry(const LDAPMapperEntry&) = delete;
LDAPMapperEntry& operator=(const LDAPMapperEntry&) = delete;
- LDAPMapperEntry(LDAPMapperEntry&&) = default;
- LDAPMapperEntry& operator=(LDAPMapperEntry&&) = default;
+ LDAPMapperEntry(LDAPMapperEntry&&) = delete;
+ LDAPMapperEntry& operator=(LDAPMapperEntry&&) = delete;
/** @brief Constructs LDAP privilege mapper entry object.
*
diff --git a/test/ldap_config_test.cpp b/test/ldap_config_test.cpp
index 6f7d1f7..b687383 100644
--- a/test/ldap_config_test.cpp
+++ b/test/ldap_config_test.cpp
@@ -28,7 +28,6 @@
using NotAllowedArgument = xyz::openbmc_project::Common::NotAllowed;
using Config = phosphor::ldap::Config;
-static constexpr const char* dbusPersistFile = "Config";
using PrivilegeMappingExists = sdbusplus::xyz::openbmc_project::User::Common::
Error::PrivilegeMappingExists;
diff --git a/user_mgr.cpp b/user_mgr.cpp
index 4a44b32..83e9f3d 100644
--- a/user_mgr.cpp
+++ b/user_mgr.cpp
@@ -686,7 +686,6 @@
* [4] - failure app
**/
-static constexpr size_t t2UserIdx = 0;
static constexpr size_t t2FailCntIdx = 1;
static constexpr size_t t2FailDateIdx = 2;
static constexpr size_t t2FailTimeIdx = 3;
diff --git a/users.hpp b/users.hpp
index a1fcc36..77a1079 100644
--- a/users.hpp
+++ b/users.hpp
@@ -113,7 +113,7 @@
/** @brief indicates if the user's password is expired
*
**/
- bool userPasswordExpired(void) const;
+ bool userPasswordExpired(void) const override;
private:
std::string userName;