commit f3fb77c042a649fc13cc917a9491a10827854258
author Nan Zhou <nanzhoumails@gmail.com> Mon Aug 29 17:51:59 2022 +0000
committer Nan Zhou <nanzhoumails@gmail.com> Mon Oct 17 02:17:34 2022 +0000
tree e76b2d71a518adbe0721b21a7be707ef023b5cb4
parent 745ce2ed79e2be3f8b66876f33e320b57f1a2ad8

treewide: make code compie on clang

This patch fixed several minor issues that clang14 complains about.

1. clang-diagnostic-inconsistent-missing-override
2. clang-diagnostic-defaulted-function-deleted
3. clang-diagnostic-unused-const-variable

Tested:
1. it builds with clang14
2. tested on hardware, ldap config daemon and user manager daemon are
both good. Tested DBus APIs (e.g., create config) as well.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: Idf8d0481fc05735b4b3d021f30aa44272f2369bf

phosphor-ldap-config/ldap_config.cpp

diff --git a/phosphor-ldap-config/ldap_config.cpp b/phosphor-ldap-config/ldap_config.cpp
index c36820d..97e23ca 100644
--- a/phosphor-ldap-config/ldap_config.cpp
+++ b/phosphor-ldap-config/ldap_config.cpp
@@ -25,7 +25,6 @@
 {
 
 constexpr auto nslcdService = "nslcd.service";
-constexpr auto nscdService = "nscd.service";
 constexpr auto LDAPscheme = "ldap";
 constexpr auto LDAPSscheme = "ldaps";
 constexpr auto certObjPath = "/xyz/openbmc_project/certs/client/ldap/1";

phosphor-ldap-config/ldap_config.hpp

diff --git a/phosphor-ldap-config/ldap_config.hpp b/phosphor-ldap-config/ldap_config.hpp
index 94c0dd2..53a777f 100644
--- a/phosphor-ldap-config/ldap_config.hpp
+++ b/phosphor-ldap-config/ldap_config.hpp
@@ -55,8 +55,8 @@
     ~Config() = default;
     Config(const Config&) = delete;
     Config& operator=(const Config&) = delete;
-    Config(Config&&) = default;
-    Config& operator=(Config&&) = default;
+    Config(Config&&) = delete;
+    Config& operator=(Config&&) = delete;
 
     /** @brief Constructor to put object onto bus at a D-Bus path.
      *  @param[in] bus - Bus to attach to.

phosphor-ldap-config/ldap_mapper_entry.hpp

diff --git a/phosphor-ldap-config/ldap_mapper_entry.hpp b/phosphor-ldap-config/ldap_mapper_entry.hpp
index 1c0c87f..93918b9 100644
--- a/phosphor-ldap-config/ldap_mapper_entry.hpp
+++ b/phosphor-ldap-config/ldap_mapper_entry.hpp
@@ -32,8 +32,8 @@
     ~LDAPMapperEntry() = default;
     LDAPMapperEntry(const LDAPMapperEntry&) = delete;
     LDAPMapperEntry& operator=(const LDAPMapperEntry&) = delete;
-    LDAPMapperEntry(LDAPMapperEntry&&) = default;
-    LDAPMapperEntry& operator=(LDAPMapperEntry&&) = default;
+    LDAPMapperEntry(LDAPMapperEntry&&) = delete;
+    LDAPMapperEntry& operator=(LDAPMapperEntry&&) = delete;
 
     /** @brief Constructs LDAP privilege mapper entry object.
      *