blob: cf623aebd8f617775f3e4177cd35f30c79ed8d73 [file] [log] [blame]
raviteja-b8cc44052019-02-27 23:29:36 -06001#include "mock_user_mgr.hpp"
Nan Zhoue47c09d2022-10-25 00:06:41 +00002#include "user_mgr.hpp"
Patrick Williams9638afb2021-02-22 17:16:24 -06003
Ravi Teja417c0892020-08-22 08:04:01 -05004#include <sdbusplus/test/sdbus_mock.hpp>
Patrick Williams9638afb2021-02-22 17:16:24 -06005#include <xyz/openbmc_project/Common/error.hpp>
6#include <xyz/openbmc_project/User/Common/error.hpp>
7
8#include <exception>
Nan Zhoue48085d2022-10-25 00:07:04 +00009#include <filesystem>
10#include <fstream>
Nan Zhouda401fe2022-10-25 00:07:18 +000011#include <vector>
Patrick Williams9638afb2021-02-22 17:16:24 -060012
Nan Zhouda401fe2022-10-25 00:07:18 +000013#include <gmock/gmock.h>
Patrick Williams9638afb2021-02-22 17:16:24 -060014#include <gtest/gtest.h>
raviteja-b8cc44052019-02-27 23:29:36 -060015
16namespace phosphor
17{
18namespace user
19{
20
21using ::testing::Return;
Alexander Filippov75626582022-02-09 18:42:37 +030022using ::testing::Throw;
raviteja-b8cc44052019-02-27 23:29:36 -060023
24using InternalFailure =
25 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure;
Alexander Filippov75626582022-02-09 18:42:37 +030026using UserNameDoesNotExist =
27 sdbusplus::xyz::openbmc_project::User::Common::Error::UserNameDoesNotExist;
raviteja-b8cc44052019-02-27 23:29:36 -060028
29class TestUserMgr : public testing::Test
30{
31 public:
Nan Zhou78d85042022-08-29 17:50:22 +000032 sdbusplus::SdBusMock sdBusMock;
Patrick Williamsb3ef4e12022-07-22 19:26:55 -050033 sdbusplus::bus_t bus;
raviteja-b8cc44052019-02-27 23:29:36 -060034 MockManager mockManager;
35
36 TestUserMgr() :
Nan Zhou78d85042022-08-29 17:50:22 +000037 bus(sdbusplus::get_mocked_new(&sdBusMock)), mockManager(bus, objpath)
Patrick Williams9638afb2021-02-22 17:16:24 -060038 {}
raviteja-b8cc44052019-02-27 23:29:36 -060039
Patrick Williams9638afb2021-02-22 17:16:24 -060040 void createLocalUser(const std::string& userName,
raviteja-b8cc44052019-02-27 23:29:36 -060041 std::vector<std::string> groupNames,
Patrick Williams9638afb2021-02-22 17:16:24 -060042 const std::string& priv, bool enabled)
raviteja-b8cc44052019-02-27 23:29:36 -060043 {
P Dheeraj Srujan Kumarb01e2fe2021-12-13 09:43:28 +053044 sdbusplus::message::object_path tempObjPath(usersObjPath);
45 tempObjPath /= userName;
46 std::string userObj(tempObjPath);
Denis Zlobine8edab52023-09-06 12:26:45 +000047 if (enabled)
48 {
49 ON_CALL(mockManager, isUserEnabled)
50 .WillByDefault(testing::Return(true));
51 }
52 else
53 {
54 ON_CALL(mockManager, isUserEnabled)
55 .WillByDefault(testing::Return(false));
56 }
raviteja-b8cc44052019-02-27 23:29:36 -060057 mockManager.usersList.emplace(
Nan Zhou78d85042022-08-29 17:50:22 +000058 userName, std::make_unique<phosphor::user::Users>(
raviteja-b8cc44052019-02-27 23:29:36 -060059 mockManager.bus, userObj.c_str(), groupNames, priv,
Nan Zhou78d85042022-08-29 17:50:22 +000060 enabled, mockManager));
raviteja-b8cc44052019-02-27 23:29:36 -060061 }
62
63 DbusUserObj createPrivilegeMapperDbusObject(void)
64 {
65 DbusUserObj object;
66 DbusUserObjValue objValue;
Ravi Teja5fe724a2019-05-07 05:14:42 -050067
Nan Zhou78d85042022-08-29 17:50:22 +000068 DbusUserObjPath objPath("/xyz/openbmc_project/user/ldap/openldap");
Ravi Teja5fe724a2019-05-07 05:14:42 -050069 DbusUserPropVariant enabled(true);
70 DbusUserObjProperties property = {std::make_pair("Enabled", enabled)};
71 std::string intf = "xyz.openbmc_project.Object.Enable";
72 objValue.emplace(intf, property);
Nan Zhou78d85042022-08-29 17:50:22 +000073 object.emplace(objPath, objValue);
Ravi Teja5fe724a2019-05-07 05:14:42 -050074
Nan Zhou78d85042022-08-29 17:50:22 +000075 DbusUserObjPath objectPath(
Ravi Teja5fe724a2019-05-07 05:14:42 -050076 "/xyz/openbmc_project/user/ldap/openldap/role_map/1");
77 std::string group = "ldapGroup";
78 std::string priv = "priv-admin";
raviteja-b8cc44052019-02-27 23:29:36 -060079 DbusUserObjProperties properties = {std::make_pair("GroupName", group),
80 std::make_pair("Privilege", priv)};
81 std::string interface = "xyz.openbmc_project.User.PrivilegeMapperEntry";
82
83 objValue.emplace(interface, properties);
Nan Zhou78d85042022-08-29 17:50:22 +000084 object.emplace(objectPath, objValue);
raviteja-b8cc44052019-02-27 23:29:36 -060085
86 return object;
87 }
Ravi Teja5fe724a2019-05-07 05:14:42 -050088
89 DbusUserObj createLdapConfigObjectWithoutPrivilegeMapper(void)
90 {
91 DbusUserObj object;
92 DbusUserObjValue objValue;
93
Nan Zhou78d85042022-08-29 17:50:22 +000094 DbusUserObjPath objPath("/xyz/openbmc_project/user/ldap/openldap");
Ravi Teja5fe724a2019-05-07 05:14:42 -050095 DbusUserPropVariant enabled(true);
96 DbusUserObjProperties property = {std::make_pair("Enabled", enabled)};
97 std::string intf = "xyz.openbmc_project.Object.Enable";
98 objValue.emplace(intf, property);
Nan Zhou78d85042022-08-29 17:50:22 +000099 object.emplace(objPath, objValue);
Ravi Teja5fe724a2019-05-07 05:14:42 -0500100 return object;
101 }
raviteja-b8cc44052019-02-27 23:29:36 -0600102};
103
104TEST_F(TestUserMgr, ldapEntryDoesNotExist)
105{
106 std::string userName = "user";
107 UserInfoMap userInfo;
108
Alexander Filippov75626582022-02-09 18:42:37 +0300109 EXPECT_CALL(mockManager, getPrimaryGroup(userName))
110 .WillRepeatedly(Throw(UserNameDoesNotExist()));
111 EXPECT_THROW(userInfo = mockManager.getUserInfo(userName),
112 UserNameDoesNotExist);
raviteja-b8cc44052019-02-27 23:29:36 -0600113}
114
115TEST_F(TestUserMgr, localUser)
116{
117 UserInfoMap userInfo;
118 std::string userName = "testUser";
119 std::string privilege = "priv-admin";
120 std::vector<std::string> groups{"testGroup"};
121 // Create local user
122 createLocalUser(userName, groups, privilege, true);
123 EXPECT_CALL(mockManager, userLockedForFailedAttempt(userName)).Times(1);
124 userInfo = mockManager.getUserInfo(userName);
125
126 EXPECT_EQ(privilege, std::get<std::string>(userInfo["UserPrivilege"]));
127 EXPECT_EQ(groups,
128 std::get<std::vector<std::string>>(userInfo["UserGroups"]));
129 EXPECT_EQ(true, std::get<bool>(userInfo["UserEnabled"]));
130 EXPECT_EQ(false, std::get<bool>(userInfo["UserLockedForFailedAttempt"]));
Joseph Reynolds3ab6cc22020-03-03 14:09:03 -0600131 EXPECT_EQ(false, std::get<bool>(userInfo["UserPasswordExpired"]));
raviteja-b8cc44052019-02-27 23:29:36 -0600132 EXPECT_EQ(false, std::get<bool>(userInfo["RemoteUser"]));
133}
134
135TEST_F(TestUserMgr, ldapUserWithPrivMapper)
136{
137 UserInfoMap userInfo;
138 std::string userName = "ldapUser";
139 std::string ldapGroup = "ldapGroup";
Alexander Filippov75626582022-02-09 18:42:37 +0300140 gid_t primaryGid = 1000;
raviteja-b8cc44052019-02-27 23:29:36 -0600141
Alexander Filippov75626582022-02-09 18:42:37 +0300142 EXPECT_CALL(mockManager, getPrimaryGroup(userName))
143 .WillRepeatedly(Return(primaryGid));
raviteja-b8cc44052019-02-27 23:29:36 -0600144 // Create privilege mapper dbus object
145 DbusUserObj object = createPrivilegeMapperDbusObject();
146 EXPECT_CALL(mockManager, getPrivilegeMapperObject())
147 .WillRepeatedly(Return(object));
Alexander Filippov75626582022-02-09 18:42:37 +0300148 EXPECT_CALL(mockManager, isGroupMember(userName, primaryGid, ldapGroup))
149 .WillRepeatedly(Return(true));
raviteja-b8cc44052019-02-27 23:29:36 -0600150 userInfo = mockManager.getUserInfo(userName);
151 EXPECT_EQ(true, std::get<bool>(userInfo["RemoteUser"]));
152 EXPECT_EQ("priv-admin", std::get<std::string>(userInfo["UserPrivilege"]));
153}
154
155TEST_F(TestUserMgr, ldapUserWithoutPrivMapper)
156{
Alexander Filippov75626582022-02-09 18:42:37 +0300157 using ::testing::_;
158
raviteja-b8cc44052019-02-27 23:29:36 -0600159 UserInfoMap userInfo;
160 std::string userName = "ldapUser";
161 std::string ldapGroup = "ldapGroup";
Alexander Filippov75626582022-02-09 18:42:37 +0300162 gid_t primaryGid = 1000;
raviteja-b8cc44052019-02-27 23:29:36 -0600163
Alexander Filippov75626582022-02-09 18:42:37 +0300164 EXPECT_CALL(mockManager, getPrimaryGroup(userName))
165 .WillRepeatedly(Return(primaryGid));
Ravi Teja5fe724a2019-05-07 05:14:42 -0500166 // Create LDAP config object without privilege mapper
167 DbusUserObj object = createLdapConfigObjectWithoutPrivilegeMapper();
raviteja-b8cc44052019-02-27 23:29:36 -0600168 EXPECT_CALL(mockManager, getPrivilegeMapperObject())
169 .WillRepeatedly(Return(object));
Alexander Filippov75626582022-02-09 18:42:37 +0300170 EXPECT_CALL(mockManager, isGroupMember(_, _, _)).Times(0);
raviteja-b8cc44052019-02-27 23:29:36 -0600171 userInfo = mockManager.getUserInfo(userName);
172 EXPECT_EQ(true, std::get<bool>(userInfo["RemoteUser"]));
Jiaqing Zhao56862062022-05-31 19:16:09 +0800173 EXPECT_EQ("priv-user", std::get<std::string>(userInfo["UserPrivilege"]));
raviteja-b8cc44052019-02-27 23:29:36 -0600174}
Nan Zhoue47c09d2022-10-25 00:06:41 +0000175
176TEST(GetCSVFromVector, EmptyVectorReturnsEmptyString)
177{
178 EXPECT_EQ(getCSVFromVector({}), "");
179}
180
181TEST(GetCSVFromVector, ElementsAreJoinedByComma)
182{
183 EXPECT_EQ(getCSVFromVector(std::vector<std::string>{"123"}), "123");
184 EXPECT_EQ(getCSVFromVector(std::vector<std::string>{"123", "456"}),
185 "123,456");
186}
187
Nan Zhou332fb9d2022-10-25 00:07:03 +0000188TEST(RemoveStringFromCSV, WithoutDeleteStringReturnsFalse)
189{
190 std::string expected = "whatever,https";
191 std::string str = expected;
192 EXPECT_FALSE(removeStringFromCSV(str, "ssh"));
193 EXPECT_EQ(str, expected);
194
195 std::string empty;
196 EXPECT_FALSE(removeStringFromCSV(empty, "ssh"));
197}
198
199TEST(RemoveStringFromCSV, WithDeleteStringReturnsTrue)
200{
201 std::string expected = "whatever";
202 std::string str = "whatever,https";
203 EXPECT_TRUE(removeStringFromCSV(str, "https"));
204 EXPECT_EQ(str, expected);
205
206 str = "https";
207 EXPECT_TRUE(removeStringFromCSV(str, "https"));
208 EXPECT_EQ(str, "");
209}
210
Nan Zhoue48085d2022-10-25 00:07:04 +0000211namespace
212{
213inline constexpr const char* objectRootInTest = "/xyz/openbmc_project/user";
214
Jason M. Bills2d042d12023-03-28 15:32:45 -0700215// Fake configs; referenced configs on real BMC
Jason M. Bills2d042d12023-03-28 15:32:45 -0700216inline constexpr const char* rawFailLockConfig = R"(
217deny=2
218unlock_time=3
219)";
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700220inline constexpr const char* rawPWHistoryConfig = R"(
221enforce_for_root
222remember=0
223)";
Jason M. Bills2d042d12023-03-28 15:32:45 -0700224inline constexpr const char* rawPWQualityConfig = R"(
225enforce_for_root
226minlen=8
227difok=0
228lcredit=0
229ocredit=0
230dcredit=0
231ucredit=0
232)";
Nan Zhoue48085d2022-10-25 00:07:04 +0000233} // namespace
234
235void dumpStringToFile(const std::string& str, const std::string& filePath)
236{
237 std::ofstream outputFileStream;
238
239 outputFileStream.exceptions(std::ofstream::failbit | std::ofstream::badbit |
240 std::ofstream::eofbit);
241
242 outputFileStream.open(filePath, std::ios::out);
243 outputFileStream << str << "\n" << std::flush;
244 outputFileStream.close();
245}
246
247void removeFile(const std::string& filePath)
248{
249 std::filesystem::remove(filePath);
250}
251
252class UserMgrInTest : public testing::Test, public UserMgr
253{
254 public:
255 UserMgrInTest() : UserMgr(busInTest, objectRootInTest)
256 {
Jason M. Bills2d042d12023-03-28 15:32:45 -0700257 tempFaillockConfigFile = "/tmp/test-data-XXXXXX";
258 mktemp(tempFaillockConfigFile.data());
259 EXPECT_NO_THROW(
260 dumpStringToFile(rawFailLockConfig, tempFaillockConfigFile));
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700261 tempPWHistoryConfigFile = "/tmp/test-data-XXXXXX";
262 mktemp(tempPWHistoryConfigFile.data());
263 EXPECT_NO_THROW(
264 dumpStringToFile(rawPWHistoryConfig, tempPWHistoryConfigFile));
Jason M. Bills2d042d12023-03-28 15:32:45 -0700265 tempPWQualityConfigFile = "/tmp/test-data-XXXXXX";
266 mktemp(tempPWQualityConfigFile.data());
267 EXPECT_NO_THROW(
268 dumpStringToFile(rawPWQualityConfig, tempPWQualityConfigFile));
Nan Zhoue48085d2022-10-25 00:07:04 +0000269 // Set config files to test files
Jason M. Bills2d042d12023-03-28 15:32:45 -0700270 faillockConfigFile = tempFaillockConfigFile;
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700271 pwHistoryConfigFile = tempPWHistoryConfigFile;
Jason M. Bills2d042d12023-03-28 15:32:45 -0700272 pwQualityConfigFile = tempPWQualityConfigFile;
Nan Zhou49c81362022-10-25 00:07:08 +0000273
Denis Zlobine8edab52023-09-06 12:26:45 +0000274 ON_CALL(*this, executeUserAdd(testing::_, testing::_, testing::_,
275 testing::Eq(true)))
276 .WillByDefault(
277 [this]() {
278 ON_CALL(*this, isUserEnabled).WillByDefault(testing::Return(true));
279 testing::Return();
280 });
281
282 ON_CALL(*this, executeUserAdd(testing::_, testing::_, testing::_,
283 testing::Eq(false)))
284 .WillByDefault(
285 [this]() {
286 ON_CALL(*this, isUserEnabled).WillByDefault(testing::Return(false));
287 testing::Return();
288 });
Nan Zhou49c81362022-10-25 00:07:08 +0000289
290 ON_CALL(*this, executeUserDelete).WillByDefault(testing::Return());
291
Jayanth Othayothac921a52023-07-21 03:48:55 -0500292 ON_CALL(*this, executeUserClearFailRecords)
293 .WillByDefault(testing::Return());
294
Nan Zhou49c81362022-10-25 00:07:08 +0000295 ON_CALL(*this, getIpmiUsersCount).WillByDefault(testing::Return(0));
Nan Zhouf25443e2022-10-25 00:07:11 +0000296
297 ON_CALL(*this, executeUserRename).WillByDefault(testing::Return());
Nan Zhoufef63032022-10-25 00:07:12 +0000298
299 ON_CALL(*this, executeUserModify(testing::_, testing::_, testing::_))
300 .WillByDefault(testing::Return());
Nan Zhou6b6f2d82022-10-25 00:07:17 +0000301
Denis Zlobine8edab52023-09-06 12:26:45 +0000302 ON_CALL(*this,
303 executeUserModifyUserEnable(testing::_, testing::Eq(true)))
304 .WillByDefault(
305 [this]() {
306 ON_CALL(*this, isUserEnabled).WillByDefault(testing::Return(true));
307 testing::Return();
308 });
309
310 ON_CALL(*this,
311 executeUserModifyUserEnable(testing::_, testing::Eq(false)))
312 .WillByDefault(
313 [this]() {
314 ON_CALL(*this, isUserEnabled).WillByDefault(testing::Return(false));
315 testing::Return();
316 });
Nan Zhouda401fe2022-10-25 00:07:18 +0000317
318 ON_CALL(*this, executeGroupCreation(testing::_))
319 .WillByDefault(testing::Return());
320
321 ON_CALL(*this, executeGroupDeletion(testing::_))
322 .WillByDefault(testing::Return());
323
324 ON_CALL(*this, executeGroupCreation).WillByDefault(testing::Return());
325
326 ON_CALL(*this, executeGroupDeletion).WillByDefault(testing::Return());
Nan Zhoue48085d2022-10-25 00:07:04 +0000327 }
328
329 ~UserMgrInTest() override
330 {
Jason M. Bills2d042d12023-03-28 15:32:45 -0700331 EXPECT_NO_THROW(removeFile(tempFaillockConfigFile));
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700332 EXPECT_NO_THROW(removeFile(tempPWHistoryConfigFile));
Jason M. Bills2d042d12023-03-28 15:32:45 -0700333 EXPECT_NO_THROW(removeFile(tempPWQualityConfigFile));
Nan Zhoue48085d2022-10-25 00:07:04 +0000334 }
335
Nan Zhou49c81362022-10-25 00:07:08 +0000336 MOCK_METHOD(void, executeUserAdd, (const char*, const char*, bool, bool),
337 (override));
338
339 MOCK_METHOD(void, executeUserDelete, (const char*), (override));
340
Jayanth Othayothac921a52023-07-21 03:48:55 -0500341 MOCK_METHOD(void, executeUserClearFailRecords, (const char*), (override));
342
Nan Zhou49c81362022-10-25 00:07:08 +0000343 MOCK_METHOD(size_t, getIpmiUsersCount, (), (override));
344
Nan Zhouf25443e2022-10-25 00:07:11 +0000345 MOCK_METHOD(void, executeUserRename, (const char*, const char*),
346 (override));
347
Nan Zhoufef63032022-10-25 00:07:12 +0000348 MOCK_METHOD(void, executeUserModify, (const char*, const char*, bool),
349 (override));
350
Nan Zhou6b6f2d82022-10-25 00:07:17 +0000351 MOCK_METHOD(void, executeUserModifyUserEnable, (const char*, bool),
352 (override));
353
Nan Zhoua2953032022-11-11 21:50:32 +0000354 MOCK_METHOD(std::vector<std::string>, getFailedAttempt, (const char*),
355 (override));
356
Nan Zhouda401fe2022-10-25 00:07:18 +0000357 MOCK_METHOD(void, executeGroupCreation, (const char*), (override));
358
359 MOCK_METHOD(void, executeGroupDeletion, (const char*), (override));
360
Denis Zlobine8edab52023-09-06 12:26:45 +0000361 MOCK_METHOD(bool, isUserEnabled, (const std::string& userName), (override));
362
Nan Zhoufef63032022-10-25 00:07:12 +0000363 protected:
Nan Zhoue48085d2022-10-25 00:07:04 +0000364 static sdbusplus::bus_t busInTest;
Jason M. Bills2d042d12023-03-28 15:32:45 -0700365 std::string tempFaillockConfigFile;
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700366 std::string tempPWHistoryConfigFile;
Jason M. Bills2d042d12023-03-28 15:32:45 -0700367 std::string tempPWQualityConfigFile;
Nan Zhoue48085d2022-10-25 00:07:04 +0000368};
369
370sdbusplus::bus_t UserMgrInTest::busInTest = sdbusplus::bus::new_default();
371
Jason M. Bills2d042d12023-03-28 15:32:45 -0700372TEST_F(UserMgrInTest, GetPamModuleConfValueOnSuccess)
373{
374 std::string minlen;
375 EXPECT_EQ(getPamModuleConfValue(tempPWQualityConfigFile, "minlen", minlen),
376 0);
377 EXPECT_EQ(minlen, "8");
378 std::string deny;
379 EXPECT_EQ(getPamModuleConfValue(tempFaillockConfigFile, "deny", deny), 0);
380 EXPECT_EQ(deny, "2");
Jason M. Bills2d042d12023-03-28 15:32:45 -0700381 std::string remember;
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700382 EXPECT_EQ(
383 getPamModuleConfValue(tempPWHistoryConfigFile, "remember", remember),
384 0);
385 EXPECT_EQ(remember, "0");
Jason M. Bills2d042d12023-03-28 15:32:45 -0700386}
387
388TEST_F(UserMgrInTest, SetPamModuleConfValueOnSuccess)
389{
390 EXPECT_EQ(setPamModuleConfValue(tempPWQualityConfigFile, "minlen", "16"),
391 0);
392 std::string minlen;
393 EXPECT_EQ(getPamModuleConfValue(tempPWQualityConfigFile, "minlen", minlen),
394 0);
395 EXPECT_EQ(minlen, "16");
396
397 EXPECT_EQ(setPamModuleConfValue(tempFaillockConfigFile, "deny", "3"), 0);
398 std::string deny;
399 EXPECT_EQ(getPamModuleConfValue(tempFaillockConfigFile, "deny", deny), 0);
400 EXPECT_EQ(deny, "3");
Nan Zhoue48085d2022-10-25 00:07:04 +0000401
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700402 EXPECT_EQ(setPamModuleConfValue(tempPWHistoryConfigFile, "remember", "1"),
403 0);
404 std::string remember;
405 EXPECT_EQ(
406 getPamModuleConfValue(tempPWHistoryConfigFile, "remember", remember),
407 0);
408 EXPECT_EQ(remember, "1");
Jason M. Bills17b88272023-05-22 14:24:02 -0700409}
410
411TEST_F(UserMgrInTest, SetPamModuleConfValueTempFileOnSuccess)
412{
413 EXPECT_EQ(setPamModuleConfValue(tempPWQualityConfigFile, "minlen", "16"),
414 0);
415
416 std::string tmpFile = tempPWQualityConfigFile + "_tmp";
417 EXPECT_FALSE(std::filesystem::exists(tmpFile));
418
419 EXPECT_EQ(setPamModuleConfValue(tempFaillockConfigFile, "deny", "3"), 0);
420
421 tmpFile = tempFaillockConfigFile + "_tmp";
422 EXPECT_FALSE(std::filesystem::exists(tmpFile));
Jason M. Bills17b88272023-05-22 14:24:02 -0700423
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700424 EXPECT_EQ(setPamModuleConfValue(tempPWHistoryConfigFile, "remember", "1"),
425 0);
Nan Zhoue48085d2022-10-25 00:07:04 +0000426
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700427 tmpFile = tempPWHistoryConfigFile + "_tmp";
428 EXPECT_FALSE(std::filesystem::exists(tmpFile));
Jason M. Bills2d042d12023-03-28 15:32:45 -0700429}
430
431TEST_F(UserMgrInTest, GetPamModuleConfValueOnFailure)
432{
433 EXPECT_NO_THROW(dumpStringToFile("whatever", tempPWQualityConfigFile));
434 std::string minlen;
435 EXPECT_EQ(getPamModuleConfValue(tempPWQualityConfigFile, "minlen", minlen),
436 -1);
437
438 EXPECT_NO_THROW(removeFile(tempPWQualityConfigFile));
439 EXPECT_EQ(getPamModuleConfValue(tempPWQualityConfigFile, "minlen", minlen),
440 -1);
441
442 EXPECT_NO_THROW(dumpStringToFile("whatever", tempFaillockConfigFile));
443 std::string deny;
444 EXPECT_EQ(getPamModuleConfValue(tempFaillockConfigFile, "deny", deny), -1);
445
446 EXPECT_NO_THROW(removeFile(tempFaillockConfigFile));
447 EXPECT_EQ(getPamModuleConfValue(tempFaillockConfigFile, "deny", deny), -1);
Nan Zhoue48085d2022-10-25 00:07:04 +0000448
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700449 EXPECT_NO_THROW(dumpStringToFile("whatever", tempPWHistoryConfigFile));
450 std::string remember;
451 EXPECT_EQ(
452 getPamModuleConfValue(tempPWHistoryConfigFile, "remember", remember),
453 -1);
Nan Zhoue48085d2022-10-25 00:07:04 +0000454
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700455 EXPECT_NO_THROW(removeFile(tempPWHistoryConfigFile));
456 EXPECT_EQ(
457 getPamModuleConfValue(tempPWHistoryConfigFile, "remember", remember),
458 -1);
Jason M. Bills2d042d12023-03-28 15:32:45 -0700459}
460
461TEST_F(UserMgrInTest, SetPamModuleConfValueOnFailure)
462{
463 EXPECT_NO_THROW(dumpStringToFile("whatever", tempPWQualityConfigFile));
464 EXPECT_EQ(setPamModuleConfValue(tempPWQualityConfigFile, "minlen", "16"),
465 -1);
466
467 EXPECT_NO_THROW(removeFile(tempPWQualityConfigFile));
468 EXPECT_EQ(setPamModuleConfValue(tempPWQualityConfigFile, "minlen", "16"),
469 -1);
470
471 EXPECT_NO_THROW(dumpStringToFile("whatever", tempFaillockConfigFile));
472 EXPECT_EQ(setPamModuleConfValue(tempFaillockConfigFile, "deny", "3"), -1);
473
474 EXPECT_NO_THROW(removeFile(tempFaillockConfigFile));
475 EXPECT_EQ(setPamModuleConfValue(tempFaillockConfigFile, "deny", "3"), -1);
Nan Zhoue48085d2022-10-25 00:07:04 +0000476
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700477 EXPECT_NO_THROW(dumpStringToFile("whatever", tempPWHistoryConfigFile));
478 EXPECT_EQ(setPamModuleConfValue(tempPWHistoryConfigFile, "remember", "1"),
479 -1);
Jason M. Bills17b88272023-05-22 14:24:02 -0700480
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700481 EXPECT_NO_THROW(removeFile(tempPWHistoryConfigFile));
482 EXPECT_EQ(setPamModuleConfValue(tempPWHistoryConfigFile, "remember", "1"),
483 -1);
Jason M. Bills17b88272023-05-22 14:24:02 -0700484}
485
486TEST_F(UserMgrInTest, SetPamModuleConfValueTempFileOnFailure)
487{
488 EXPECT_NO_THROW(dumpStringToFile("whatever", tempPWQualityConfigFile));
489 EXPECT_EQ(setPamModuleConfValue(tempPWQualityConfigFile, "minlen", "16"),
490 -1);
491
492 std::string tmpFile = tempPWQualityConfigFile + "_tmp";
493 EXPECT_FALSE(std::filesystem::exists(tmpFile));
494
495 EXPECT_NO_THROW(removeFile(tempPWQualityConfigFile));
496 EXPECT_EQ(setPamModuleConfValue(tempPWQualityConfigFile, "minlen", "16"),
497 -1);
498
499 EXPECT_FALSE(std::filesystem::exists(tmpFile));
500
501 EXPECT_NO_THROW(dumpStringToFile("whatever", tempFaillockConfigFile));
502 EXPECT_EQ(setPamModuleConfValue(tempFaillockConfigFile, "deny", "3"), -1);
503
504 tmpFile = tempFaillockConfigFile + "_tmp";
505 EXPECT_FALSE(std::filesystem::exists(tmpFile));
506
507 EXPECT_NO_THROW(removeFile(tempFaillockConfigFile));
508 EXPECT_EQ(setPamModuleConfValue(tempFaillockConfigFile, "deny", "3"), -1);
509
510 EXPECT_FALSE(std::filesystem::exists(tmpFile));
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700511
512 EXPECT_NO_THROW(dumpStringToFile("whatever", tempPWHistoryConfigFile));
513 EXPECT_EQ(setPamModuleConfValue(tempPWHistoryConfigFile, "remember", "1"),
514 -1);
515
516 tmpFile = tempPWHistoryConfigFile + "_tmp";
517 EXPECT_FALSE(std::filesystem::exists(tmpFile));
518
519 EXPECT_NO_THROW(removeFile(tempPWHistoryConfigFile));
520 EXPECT_EQ(setPamModuleConfValue(tempPWHistoryConfigFile, "remember", "1"),
521 -1);
522
523 EXPECT_FALSE(std::filesystem::exists(tmpFile));
Jason M. Bills17b88272023-05-22 14:24:02 -0700524}
525
Nan Zhou8a11d992022-10-25 00:07:06 +0000526TEST_F(UserMgrInTest, IsUserExistEmptyInputThrowsError)
527{
528 EXPECT_THROW(
529 isUserExist(""),
530 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
531}
532
533TEST_F(UserMgrInTest, ThrowForUserDoesNotExistThrowsError)
534{
535 EXPECT_THROW(throwForUserDoesNotExist("whatever"),
536 sdbusplus::xyz::openbmc_project::User::Common::Error::
537 UserNameDoesNotExist);
538}
539
540TEST_F(UserMgrInTest, ThrowForUserExistsThrowsError)
541{
542 EXPECT_THROW(
543 throwForUserExists("root"),
544 sdbusplus::xyz::openbmc_project::User::Common::Error::UserNameExists);
545}
546
Nan Zhou40e44972022-10-25 00:07:07 +0000547TEST_F(
548 UserMgrInTest,
549 ThrowForUserNameConstraintsExceedIpmiMaxUserNameLenThrowsUserNameGroupFail)
550{
551 std::string strWith17Chars(17, 'A');
552 EXPECT_THROW(throwForUserNameConstraints(strWith17Chars, {"ipmi"}),
553 sdbusplus::xyz::openbmc_project::User::Common::Error::
554 UserNameGroupFail);
555}
556
557TEST_F(
558 UserMgrInTest,
559 ThrowForUserNameConstraintsExceedSystemMaxUserNameLenThrowsInvalidArgument)
560{
561 std::string strWith31Chars(31, 'A');
562 EXPECT_THROW(
563 throwForUserNameConstraints(strWith31Chars, {}),
564 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
565}
566
567TEST_F(UserMgrInTest,
568 ThrowForUserNameConstraintsRegexMismatchThrowsInvalidArgument)
569{
570 std::string startWithNumber = "0ABC";
571 EXPECT_THROW(
572 throwForUserNameConstraints(startWithNumber, {"ipmi"}),
573 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
574}
575
Nan Zhou49c81362022-10-25 00:07:08 +0000576TEST_F(UserMgrInTest, UserAddNotRootFailedWithInternalFailure)
577{
578 EXPECT_THROW(
579 UserMgr::executeUserAdd("user0", "ipmi,ssh", true, true),
580 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
581}
582
583TEST_F(UserMgrInTest, UserDeleteNotRootFailedWithInternalFailure)
584{
585 EXPECT_THROW(
586 UserMgr::executeUserDelete("user0"),
587 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
588}
589
590TEST_F(UserMgrInTest,
591 ThrowForMaxGrpUserCountThrowsNoResourceWhenIpmiUserExceedLimit)
592{
593 EXPECT_CALL(*this, getIpmiUsersCount()).WillOnce(Return(ipmiMaxUsers));
594 EXPECT_THROW(
595 throwForMaxGrpUserCount({"ipmi"}),
596 sdbusplus::xyz::openbmc_project::User::Common::Error::NoResource);
597}
598
599TEST_F(UserMgrInTest, CreateUserThrowsInternalFailureWhenExecuteUserAddFails)
600{
601 EXPECT_CALL(*this, executeUserAdd)
602 .WillOnce(testing::Throw(
603 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure()));
604 EXPECT_THROW(
605 createUser("whatever", {"redfish"}, "", true),
606 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
607}
608
609TEST_F(UserMgrInTest, DeleteUserThrowsInternalFailureWhenExecuteUserDeleteFails)
610{
611 std::string username = "user";
612 EXPECT_NO_THROW(
613 UserMgr::createUser(username, {"redfish", "ssh"}, "priv-user", true));
614 EXPECT_CALL(*this, executeUserDelete(testing::StrEq(username)))
615 .WillOnce(testing::Throw(
616 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure()))
617 .WillOnce(testing::DoDefault());
618
619 EXPECT_THROW(
620 deleteUser(username),
621 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
622 EXPECT_NO_THROW(UserMgr::deleteUser(username));
623}
624
Jayanth Othayothac921a52023-07-21 03:48:55 -0500625TEST_F(UserMgrInTest,
626 DeleteUserThrowsInternalFailureWhenExecuteUserClearFailRecords)
627{
628 const char* username = "user";
629 EXPECT_NO_THROW(
630 UserMgr::createUser(username, {"redfish", "ssh"}, "priv-user", true));
631 EXPECT_CALL(*this, executeUserClearFailRecords(testing::StrEq(username)))
632 .WillOnce(testing::Throw(
633 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure()))
634 .WillOnce(testing::DoDefault());
635
636 EXPECT_THROW(
637 deleteUser(username),
638 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
639 EXPECT_NO_THROW(UserMgr::deleteUser(username));
640}
641
Nan Zhou589aeb42022-10-25 00:07:09 +0000642TEST_F(UserMgrInTest, ThrowForInvalidPrivilegeThrowsWhenPrivilegeIsInvalid)
643{
644 EXPECT_THROW(
645 throwForInvalidPrivilege("whatever"),
646 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
647}
648
649TEST_F(UserMgrInTest, ThrowForInvalidPrivilegeNoThrowWhenPrivilegeIsValid)
650{
651 EXPECT_NO_THROW(throwForInvalidPrivilege("priv-admin"));
652 EXPECT_NO_THROW(throwForInvalidPrivilege("priv-operator"));
653 EXPECT_NO_THROW(throwForInvalidPrivilege("priv-user"));
Nan Zhou589aeb42022-10-25 00:07:09 +0000654}
655
Nan Zhouecf88762022-10-25 00:07:10 +0000656TEST_F(UserMgrInTest, ThrowForInvalidGroupsThrowsWhenGroupIsInvalid)
657{
658 EXPECT_THROW(
659 throwForInvalidGroups({"whatever"}),
660 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
661}
662
663TEST_F(UserMgrInTest, ThrowForInvalidGroupsNoThrowWhenGroupIsValid)
664{
665 EXPECT_NO_THROW(throwForInvalidGroups({"ipmi"}));
666 EXPECT_NO_THROW(throwForInvalidGroups({"ssh"}));
667 EXPECT_NO_THROW(throwForInvalidGroups({"redfish"}));
668 EXPECT_NO_THROW(throwForInvalidGroups({"web"}));
Ninad Palsule601d3db2023-03-09 10:27:37 -0600669 EXPECT_NO_THROW(throwForInvalidGroups({"hostconsole"}));
Nan Zhouecf88762022-10-25 00:07:10 +0000670}
671
Nan Zhouf25443e2022-10-25 00:07:11 +0000672TEST_F(UserMgrInTest, RenameUserOnSuccess)
673{
674 std::string username = "user001";
675 EXPECT_NO_THROW(
676 UserMgr::createUser(username, {"redfish", "ssh"}, "priv-user", true));
677 std::string newUsername = "user002";
678
679 EXPECT_NO_THROW(UserMgr::renameUser(username, newUsername));
680
681 // old username doesn't exist
682 EXPECT_THROW(getUserInfo(username),
683 sdbusplus::xyz::openbmc_project::User::Common::Error::
684 UserNameDoesNotExist);
685
686 UserInfoMap userInfo = getUserInfo(newUsername);
687 EXPECT_EQ(std::get<Privilege>(userInfo["UserPrivilege"]), "priv-user");
688 EXPECT_THAT(std::get<GroupList>(userInfo["UserGroups"]),
689 testing::UnorderedElementsAre("redfish", "ssh"));
690 EXPECT_EQ(std::get<UserEnabled>(userInfo["UserEnabled"]), true);
691
692 EXPECT_NO_THROW(UserMgr::deleteUser(newUsername));
693}
694
695TEST_F(UserMgrInTest, RenameUserThrowsInternalFailureIfExecuteUserModifyFails)
696{
697 std::string username = "user001";
698 EXPECT_NO_THROW(
699 UserMgr::createUser(username, {"redfish", "ssh"}, "priv-user", true));
700 std::string newUsername = "user002";
701
702 EXPECT_CALL(*this, executeUserRename(testing::StrEq(username),
703 testing::StrEq(newUsername)))
704 .WillOnce(testing::Throw(
705 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure()));
706 EXPECT_THROW(
707 UserMgr::renameUser(username, newUsername),
708 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
709
710 // The original user is unchanged
711 UserInfoMap userInfo = getUserInfo(username);
712 EXPECT_EQ(std::get<Privilege>(userInfo["UserPrivilege"]), "priv-user");
713 EXPECT_THAT(std::get<GroupList>(userInfo["UserGroups"]),
714 testing::UnorderedElementsAre("redfish", "ssh"));
715 EXPECT_EQ(std::get<UserEnabled>(userInfo["UserEnabled"]), true);
716
717 EXPECT_NO_THROW(UserMgr::deleteUser(username));
718}
719
720TEST_F(UserMgrInTest, DefaultUserModifyFailedWithInternalFailure)
721{
722 EXPECT_THROW(
723 UserMgr::executeUserRename("user0", "user1"),
724 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
Nan Zhoufef63032022-10-25 00:07:12 +0000725 EXPECT_THROW(
726 UserMgr::executeUserModify("user0", "ssh", true),
727 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
728}
729
730TEST_F(UserMgrInTest, UpdateGroupsAndPrivOnSuccess)
731{
732 std::string username = "user001";
733 EXPECT_NO_THROW(
734 UserMgr::createUser(username, {"redfish", "ssh"}, "priv-user", true));
735 EXPECT_NO_THROW(
736 updateGroupsAndPriv(username, {"ipmi", "ssh"}, "priv-admin"));
737 UserInfoMap userInfo = getUserInfo(username);
738 EXPECT_EQ(std::get<Privilege>(userInfo["UserPrivilege"]), "priv-admin");
739 EXPECT_THAT(std::get<GroupList>(userInfo["UserGroups"]),
740 testing::UnorderedElementsAre("ipmi", "ssh"));
741 EXPECT_EQ(std::get<UserEnabled>(userInfo["UserEnabled"]), true);
742 EXPECT_NO_THROW(UserMgr::deleteUser(username));
743}
744
745TEST_F(UserMgrInTest,
746 UpdateGroupsAndPrivThrowsInternalFailureIfExecuteUserModifyFail)
747{
748 std::string username = "user001";
749 EXPECT_NO_THROW(
750 UserMgr::createUser(username, {"redfish", "ssh"}, "priv-user", true));
751 EXPECT_CALL(*this, executeUserModify(testing::StrEq(username), testing::_,
752 testing::_))
753 .WillOnce(testing::Throw(
754 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure()));
755 EXPECT_THROW(
756 updateGroupsAndPriv(username, {"ipmi", "ssh"}, "priv-admin"),
757 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
758 EXPECT_NO_THROW(UserMgr::deleteUser(username));
Nan Zhouf25443e2022-10-25 00:07:11 +0000759}
760
Nan Zhou18031012022-11-10 22:24:58 +0000761TEST_F(UserMgrInTest, MinPasswordLengthReturnsIfValueIsTheSame)
762{
763 initializeAccountPolicy();
764 EXPECT_EQ(AccountPolicyIface::minPasswordLength(), 8);
765 UserMgr::minPasswordLength(8);
766 EXPECT_EQ(AccountPolicyIface::minPasswordLength(), 8);
767}
768
769TEST_F(UserMgrInTest,
770 MinPasswordLengthRejectsTooShortPasswordWithInvalidArgument)
771{
772 initializeAccountPolicy();
773 EXPECT_EQ(AccountPolicyIface::minPasswordLength(), 8);
774 EXPECT_THROW(
775 UserMgr::minPasswordLength(minPasswdLength - 1),
776 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
777 EXPECT_EQ(AccountPolicyIface::minPasswordLength(), 8);
778}
779
780TEST_F(UserMgrInTest, MinPasswordLengthOnSuccess)
781{
782 initializeAccountPolicy();
783 EXPECT_EQ(AccountPolicyIface::minPasswordLength(), 8);
784 UserMgr::minPasswordLength(16);
785 EXPECT_EQ(AccountPolicyIface::minPasswordLength(), 16);
786}
787
788TEST_F(UserMgrInTest, MinPasswordLengthOnFailure)
789{
Jason M. Bills2d042d12023-03-28 15:32:45 -0700790 EXPECT_NO_THROW(dumpStringToFile("whatever", tempPWQualityConfigFile));
Nan Zhou18031012022-11-10 22:24:58 +0000791 initializeAccountPolicy();
792 EXPECT_EQ(AccountPolicyIface::minPasswordLength(), 8);
793 EXPECT_THROW(
794 UserMgr::minPasswordLength(16),
795 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
796 EXPECT_EQ(AccountPolicyIface::minPasswordLength(), 8);
797}
798
Nan Zhoua6ce1fa2022-10-25 00:07:14 +0000799TEST_F(UserMgrInTest, RememberOldPasswordTimesReturnsIfValueIsTheSame)
800{
801 initializeAccountPolicy();
802 EXPECT_EQ(AccountPolicyIface::rememberOldPasswordTimes(), 0);
803 UserMgr::rememberOldPasswordTimes(8);
804 EXPECT_EQ(AccountPolicyIface::rememberOldPasswordTimes(), 8);
805 UserMgr::rememberOldPasswordTimes(8);
806 EXPECT_EQ(AccountPolicyIface::rememberOldPasswordTimes(), 8);
807}
808
809TEST_F(UserMgrInTest, RememberOldPasswordTimesOnSuccess)
810{
811 initializeAccountPolicy();
812 EXPECT_EQ(AccountPolicyIface::rememberOldPasswordTimes(), 0);
813 UserMgr::rememberOldPasswordTimes(16);
814 EXPECT_EQ(AccountPolicyIface::rememberOldPasswordTimes(), 16);
815}
816
817TEST_F(UserMgrInTest, RememberOldPasswordTimesOnFailure)
818{
Jason M. Bills3b280ec2023-08-15 16:15:48 -0700819 EXPECT_NO_THROW(dumpStringToFile("whatever", tempPWHistoryConfigFile));
Nan Zhoua6ce1fa2022-10-25 00:07:14 +0000820 initializeAccountPolicy();
821 EXPECT_EQ(AccountPolicyIface::rememberOldPasswordTimes(), 0);
822 EXPECT_THROW(
823 UserMgr::rememberOldPasswordTimes(16),
824 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
825 EXPECT_EQ(AccountPolicyIface::rememberOldPasswordTimes(), 0);
826}
827
Nan Zhoucfabe6b2022-10-25 00:07:15 +0000828TEST_F(UserMgrInTest, MaxLoginAttemptBeforeLockoutReturnsIfValueIsTheSame)
829{
830 initializeAccountPolicy();
831 EXPECT_EQ(AccountPolicyIface::maxLoginAttemptBeforeLockout(), 2);
832 UserMgr::maxLoginAttemptBeforeLockout(2);
833 EXPECT_EQ(AccountPolicyIface::maxLoginAttemptBeforeLockout(), 2);
834}
835
836TEST_F(UserMgrInTest, MaxLoginAttemptBeforeLockoutOnSuccess)
837{
838 initializeAccountPolicy();
839 EXPECT_EQ(AccountPolicyIface::maxLoginAttemptBeforeLockout(), 2);
840 UserMgr::maxLoginAttemptBeforeLockout(16);
841 EXPECT_EQ(AccountPolicyIface::maxLoginAttemptBeforeLockout(), 16);
842}
843
844TEST_F(UserMgrInTest, MaxLoginAttemptBeforeLockoutOnFailure)
845{
Nan Zhoucfabe6b2022-10-25 00:07:15 +0000846 initializeAccountPolicy();
Jason M. Bills2d042d12023-03-28 15:32:45 -0700847 EXPECT_NO_THROW(dumpStringToFile("whatever", tempFaillockConfigFile));
Nan Zhoucfabe6b2022-10-25 00:07:15 +0000848 EXPECT_THROW(
849 UserMgr::maxLoginAttemptBeforeLockout(16),
850 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
Jason M. Bills2d042d12023-03-28 15:32:45 -0700851 EXPECT_EQ(AccountPolicyIface::maxLoginAttemptBeforeLockout(), 2);
Nan Zhoucfabe6b2022-10-25 00:07:15 +0000852}
853
Nan Zhou784aecd2022-10-25 00:07:16 +0000854TEST_F(UserMgrInTest, AccountUnlockTimeoutReturnsIfValueIsTheSame)
855{
856 initializeAccountPolicy();
857 EXPECT_EQ(AccountPolicyIface::accountUnlockTimeout(), 3);
858 UserMgr::accountUnlockTimeout(3);
859 EXPECT_EQ(AccountPolicyIface::accountUnlockTimeout(), 3);
860}
861
862TEST_F(UserMgrInTest, AccountUnlockTimeoutOnSuccess)
863{
864 initializeAccountPolicy();
865 EXPECT_EQ(AccountPolicyIface::accountUnlockTimeout(), 3);
866 UserMgr::accountUnlockTimeout(16);
867 EXPECT_EQ(AccountPolicyIface::accountUnlockTimeout(), 16);
868}
869
870TEST_F(UserMgrInTest, AccountUnlockTimeoutOnFailure)
871{
872 initializeAccountPolicy();
Jason M. Bills2d042d12023-03-28 15:32:45 -0700873 EXPECT_NO_THROW(dumpStringToFile("whatever", tempFaillockConfigFile));
Nan Zhou784aecd2022-10-25 00:07:16 +0000874 EXPECT_THROW(
875 UserMgr::accountUnlockTimeout(16),
876 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
877 EXPECT_EQ(AccountPolicyIface::accountUnlockTimeout(), 3);
878}
879
Nan Zhou6b6f2d82022-10-25 00:07:17 +0000880TEST_F(UserMgrInTest, UserEnableOnSuccess)
881{
882 std::string username = "user001";
883 EXPECT_NO_THROW(
884 UserMgr::createUser(username, {"redfish", "ssh"}, "priv-user", true));
885 UserInfoMap userInfo = getUserInfo(username);
886 EXPECT_EQ(std::get<UserEnabled>(userInfo["UserEnabled"]), true);
887
888 EXPECT_NO_THROW(userEnable(username, false));
889
890 userInfo = getUserInfo(username);
891 EXPECT_EQ(std::get<UserEnabled>(userInfo["UserEnabled"]), false);
892
893 EXPECT_NO_THROW(UserMgr::deleteUser(username));
894}
895
Ninad Palsule601d3db2023-03-09 10:27:37 -0600896TEST_F(UserMgrInTest, CreateDeleteUserSuccessForHostConsole)
897{
898 std::string username = "user001";
899 EXPECT_NO_THROW(
900 UserMgr::createUser(username, {"hostconsole"}, "priv-user", true));
901 EXPECT_NO_THROW(UserMgr::deleteUser(username));
902 EXPECT_NO_THROW(
903 UserMgr::createUser(username, {"hostconsole"}, "priv-admin", true));
904 EXPECT_NO_THROW(UserMgr::deleteUser(username));
905 EXPECT_NO_THROW(
906 UserMgr::createUser(username, {"hostconsole"}, "priv-operator", true));
907 EXPECT_NO_THROW(UserMgr::deleteUser(username));
908}
909
Nan Zhou6b6f2d82022-10-25 00:07:17 +0000910TEST_F(UserMgrInTest, UserEnableThrowsInternalFailureIfExecuteUserModifyFail)
911{
912 std::string username = "user001";
913 EXPECT_NO_THROW(
914 UserMgr::createUser(username, {"redfish", "ssh"}, "priv-user", true));
915 UserInfoMap userInfo = getUserInfo(username);
916 EXPECT_EQ(std::get<UserEnabled>(userInfo["UserEnabled"]), true);
917
918 EXPECT_CALL(*this, executeUserModifyUserEnable(testing::StrEq(username),
919 testing::Eq(false)))
920 .WillOnce(testing::Throw(
921 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure()));
922 EXPECT_THROW(
923 userEnable(username, false),
924 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
925
926 userInfo = getUserInfo(username);
927 // Stay unchanged
928 EXPECT_EQ(std::get<UserEnabled>(userInfo["UserEnabled"]), true);
929
930 EXPECT_NO_THROW(UserMgr::deleteUser(username));
931}
932
Nan Zhoua2953032022-11-11 21:50:32 +0000933TEST_F(
934 UserMgrInTest,
935 UserLockedForFailedAttemptReturnsFalseIfMaxLoginAttemptBeforeLockoutIsZero)
936{
937 EXPECT_FALSE(userLockedForFailedAttempt("whatever"));
938}
939
940TEST_F(UserMgrInTest, UserLockedForFailedAttemptZeroFailuresReturnsFalse)
941{
942 std::string username = "user001";
943 initializeAccountPolicy();
944 // Example output from BMC
Jason M. Bills2d042d12023-03-28 15:32:45 -0700945 // root:~# faillock --user root
946 // root:
947 // When Type Source Valid
948 std::vector<std::string> output = {"whatever",
949 "When Type Source Valid"};
Nan Zhoua2953032022-11-11 21:50:32 +0000950 EXPECT_CALL(*this, getFailedAttempt(testing::StrEq(username.c_str())))
951 .WillOnce(testing::Return(output));
952
953 EXPECT_FALSE(userLockedForFailedAttempt(username));
954}
955
956TEST_F(UserMgrInTest, UserLockedForFailedAttemptFailIfGetFailedAttemptFail)
957{
958 std::string username = "user001";
959 initializeAccountPolicy();
960 EXPECT_CALL(*this, getFailedAttempt(testing::StrEq(username.c_str())))
961 .WillOnce(testing::Throw(
962 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure()));
963
964 EXPECT_THROW(
965 userLockedForFailedAttempt(username),
966 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
967}
968
969TEST_F(UserMgrInTest,
Nan Zhoua2953032022-11-11 21:50:32 +0000970 UserLockedForFailedAttemptThrowsInternalFailureIfWrongDateFormat)
971{
972 std::string username = "user001";
973 initializeAccountPolicy();
974
975 // Choose a date in the past.
976 std::vector<std::string> output = {"whatever",
Jason M. Bills2d042d12023-03-28 15:32:45 -0700977 "10/24/2002 00:00:00 type source V"};
Nan Zhoua2953032022-11-11 21:50:32 +0000978 EXPECT_CALL(*this, getFailedAttempt(testing::StrEq(username.c_str())))
979 .WillOnce(testing::Return(output));
980
981 EXPECT_THROW(
982 userLockedForFailedAttempt(username),
983 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
984}
985
986TEST_F(UserMgrInTest,
987 UserLockedForFailedAttemptReturnsFalseIfLastFailTimeHasTimedOut)
988{
989 std::string username = "user001";
990 initializeAccountPolicy();
991
992 // Choose a date in the past.
993 std::vector<std::string> output = {"whatever",
Jason M. Bills2d042d12023-03-28 15:32:45 -0700994 "2002-10-24 00:00:00 type source V"};
Nan Zhoua2953032022-11-11 21:50:32 +0000995 EXPECT_CALL(*this, getFailedAttempt(testing::StrEq(username.c_str())))
996 .WillOnce(testing::Return(output));
997
998 EXPECT_EQ(userLockedForFailedAttempt(username), false);
999}
1000
Nan Zhouda401fe2022-10-25 00:07:18 +00001001TEST_F(UserMgrInTest, CheckAndThrowForDisallowedGroupCreationOnSuccess)
1002{
1003 // Base Redfish Roles
1004 EXPECT_NO_THROW(
1005 checkAndThrowForDisallowedGroupCreation("openbmc_rfr_Administrator"));
1006 EXPECT_NO_THROW(
1007 checkAndThrowForDisallowedGroupCreation("openbmc_rfr_Operator"));
1008 EXPECT_NO_THROW(
1009 checkAndThrowForDisallowedGroupCreation("openbmc_rfr_ReadOnly"));
1010 // Base Redfish Privileges
1011 EXPECT_NO_THROW(
1012 checkAndThrowForDisallowedGroupCreation("openbmc_rfp_Login"));
1013 EXPECT_NO_THROW(checkAndThrowForDisallowedGroupCreation(
1014 "openbmc_rfp_ConfigureManager"));
1015 EXPECT_NO_THROW(
1016 checkAndThrowForDisallowedGroupCreation("openbmc_rfp_ConfigureUsers"));
1017 EXPECT_NO_THROW(
1018 checkAndThrowForDisallowedGroupCreation("openbmc_rfp_ConfigureSelf"));
1019 EXPECT_NO_THROW(checkAndThrowForDisallowedGroupCreation(
1020 "openbmc_rfp_ConfigureComponents"));
1021 // OEM Redfish Roles
1022 EXPECT_NO_THROW(
1023 checkAndThrowForDisallowedGroupCreation("openbmc_orfr_PowerService"));
1024 // OEM Redfish Privileges
1025 EXPECT_NO_THROW(
1026 checkAndThrowForDisallowedGroupCreation("openbmc_orfp_PowerService"));
1027}
1028
1029TEST_F(UserMgrInTest,
1030 CheckAndThrowForDisallowedGroupCreationThrowsIfGroupNameTooLong)
1031{
1032 std::string groupName(maxSystemGroupNameLength + 1, 'A');
1033 EXPECT_THROW(
1034 checkAndThrowForDisallowedGroupCreation(groupName),
1035 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
1036}
1037
1038TEST_F(
1039 UserMgrInTest,
1040 CheckAndThrowForDisallowedGroupCreationThrowsIfGroupNameHasDisallowedCharacters)
1041{
Nan Zhouda401fe2022-10-25 00:07:18 +00001042 EXPECT_THROW(
1043 checkAndThrowForDisallowedGroupCreation("openbmc_rfp_?owerService"),
1044 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
1045 EXPECT_THROW(
1046 checkAndThrowForDisallowedGroupCreation("openbmc_rfp_-owerService"),
1047 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
1048}
1049
1050TEST_F(
1051 UserMgrInTest,
1052 CheckAndThrowForDisallowedGroupCreationThrowsIfGroupNameHasDisallowedPrefix)
1053{
Nan Zhouda401fe2022-10-25 00:07:18 +00001054 EXPECT_THROW(
1055 checkAndThrowForDisallowedGroupCreation("google_rfp_"),
1056 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
1057 EXPECT_THROW(
1058 checkAndThrowForDisallowedGroupCreation("com_rfp_"),
1059 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
1060}
1061
1062TEST_F(UserMgrInTest, CheckAndThrowForMaxGroupCountOnSuccess)
1063{
Ninad Palsule601d3db2023-03-09 10:27:37 -06001064 constexpr size_t predefGroupCount = 5;
1065
1066 EXPECT_THAT(allGroups().size(), predefGroupCount);
1067 for (size_t i = 0; i < maxSystemGroupCount - predefGroupCount; ++i)
Nan Zhouda401fe2022-10-25 00:07:18 +00001068 {
1069 std::string groupName = "openbmc_rfr_role";
1070 groupName += std::to_string(i);
1071 EXPECT_NO_THROW(createGroup(groupName));
1072 }
1073 EXPECT_THROW(
1074 createGroup("openbmc_rfr_AnotherRole"),
1075 sdbusplus::xyz::openbmc_project::User::Common::Error::NoResource);
Ninad Palsule601d3db2023-03-09 10:27:37 -06001076 for (size_t i = 0; i < maxSystemGroupCount - predefGroupCount; ++i)
Nan Zhouda401fe2022-10-25 00:07:18 +00001077 {
1078 std::string groupName = "openbmc_rfr_role";
1079 groupName += std::to_string(i);
1080 EXPECT_NO_THROW(deleteGroup(groupName));
1081 }
1082}
1083
1084TEST_F(UserMgrInTest, CheckAndThrowForGroupExist)
1085{
1086 std::string groupName = "openbmc_rfr_role";
1087 EXPECT_NO_THROW(createGroup(groupName));
1088 EXPECT_THROW(
1089 createGroup(groupName),
1090 sdbusplus::xyz::openbmc_project::User::Common::Error::GroupNameExists);
1091 EXPECT_NO_THROW(deleteGroup(groupName));
1092}
1093
1094TEST_F(UserMgrInTest, ByDefaultAllGroupsArePredefinedGroups)
1095{
1096 EXPECT_THAT(allGroups(),
Ninad Palsule601d3db2023-03-09 10:27:37 -06001097 testing::UnorderedElementsAre("web", "redfish", "ipmi", "ssh",
1098 "hostconsole"));
1099}
1100
1101TEST_F(UserMgrInTest, AddGroupThrowsIfPreDefinedGroupAdd)
1102{
1103 EXPECT_THROW(
1104 createGroup("ipmi"),
1105 sdbusplus::xyz::openbmc_project::User::Common::Error::GroupNameExists);
1106 EXPECT_THROW(
1107 createGroup("web"),
1108 sdbusplus::xyz::openbmc_project::User::Common::Error::GroupNameExists);
1109 EXPECT_THROW(
1110 createGroup("redfish"),
1111 sdbusplus::xyz::openbmc_project::User::Common::Error::GroupNameExists);
1112 EXPECT_THROW(
1113 createGroup("ssh"),
1114 sdbusplus::xyz::openbmc_project::User::Common::Error::GroupNameExists);
1115 EXPECT_THROW(
1116 createGroup("hostconsole"),
1117 sdbusplus::xyz::openbmc_project::User::Common::Error::GroupNameExists);
Nan Zhouda401fe2022-10-25 00:07:18 +00001118}
1119
1120TEST_F(UserMgrInTest, DeleteGroupThrowsIfGroupIsNotAllowedToChange)
1121{
1122 EXPECT_THROW(
1123 deleteGroup("ipmi"),
1124 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
1125 EXPECT_THROW(
1126 deleteGroup("web"),
1127 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
1128 EXPECT_THROW(
1129 deleteGroup("redfish"),
1130 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
1131 EXPECT_THROW(
1132 deleteGroup("ssh"),
1133 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
Ninad Palsule601d3db2023-03-09 10:27:37 -06001134 EXPECT_THROW(
1135 deleteGroup("hostconsole"),
1136 sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument);
Nan Zhouda401fe2022-10-25 00:07:18 +00001137}
1138
1139TEST_F(UserMgrInTest,
1140 CreateGroupThrowsInternalFailureWhenExecuteGroupCreateFails)
1141{
1142 EXPECT_CALL(*this, executeGroupCreation)
1143 .WillOnce(testing::Throw(
1144 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure()));
1145 EXPECT_THROW(
1146 createGroup("openbmc_rfr_role1"),
1147 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
1148}
1149
1150TEST_F(UserMgrInTest,
1151 DeleteGroupThrowsInternalFailureWhenExecuteGroupDeleteFails)
1152{
1153 std::string groupName = "openbmc_rfr_role1";
1154 EXPECT_NO_THROW(UserMgr::createGroup(groupName));
1155 EXPECT_CALL(*this, executeGroupDeletion(testing::StrEq(groupName)))
1156 .WillOnce(testing::Throw(
1157 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure()))
1158 .WillOnce(testing::DoDefault());
1159
1160 EXPECT_THROW(
1161 deleteGroup(groupName),
1162 sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure);
1163 EXPECT_NO_THROW(UserMgr::deleteGroup(groupName));
1164}
1165
1166TEST_F(UserMgrInTest, CheckAndThrowForGroupNotExist)
1167{
1168 EXPECT_THROW(deleteGroup("whatever"),
1169 sdbusplus::xyz::openbmc_project::User::Common::Error::
1170 GroupNameDoesNotExist);
1171}
1172
1173TEST(ReadAllGroupsOnSystemTest, OnlyReturnsPredefinedGroups)
1174{
1175 EXPECT_THAT(UserMgr::readAllGroupsOnSystem(),
Ninad Palsule601d3db2023-03-09 10:27:37 -06001176 testing::UnorderedElementsAre("web", "redfish", "ipmi", "ssh",
1177 "hostconsole"));
Nan Zhouda401fe2022-10-25 00:07:18 +00001178}
1179
raviteja-b8cc44052019-02-27 23:29:36 -06001180} // namespace user
1181} // namespace phosphor