tree 69ecd89ee1904716e7538e543078527b4fe2e227
parent 8859c84bdc1f994405cf617accc3d0f47801587a
author Matt Spinler <spinler@us.ibm.com> 1675717964 -0600
committer Matt Spinler <spinler@us.ibm.com> 1675719025 -0600

Fixes around persisting values in entity-manager

This fixes three problems that were causing "Faild to set dbus
property." error traces to show up.

1. In VirtualSensor::createThresholds() the setEntityPath() and
   setEntityInterfaceHigh/Low() calls have to be made on the threshold
   objects before the critical/warning/High/Low() functions are called
   so that the path and interface is known for the property set call.
   Reorder the code so this is the case.

2. Saving the value in entity-manager only works when the virtual sensor
   config was obtained from entity-manager D-Bus objects, and not when
   it was obtained from virtual_sensor_config.json.  In the latter case,
   the 'entityPath' variable won't have a value, so check for that
   before trying to set a property on entity-manager.

3. If either a 'high' or 'low' threshold property isn't set, then the
   'entityInterfaceHigh/Low' variable will be empty.  Also skip the
   property write in that case.

Tested:  No more error traces, and verified that changing a threshold
value on a virtual sensor is still reflected in entity-manager when its
config was from EM in the first place.

Change-Id: I67dc35fb4b8f4c1367231e22ddde91fbd1bb354d
Signed-off-by: Matt Spinler <spinler@us.ibm.com>