commit cf4ce3c171cf222fd5920c173a0b7efadb674fe0
author Willy Tu <wltu@google.com> Thu Dec 09 20:39:37 2021 -0800
committer Willy Tu <wltu@google.com> Fri Dec 10 16:20:39 2021 -0800
tree e83eb2467d21a781c3b558bbaa416eb9a8f35514
parent 6a54155eab9bab579bc9493199a4272676563b5f

phosphor-watchdog: Cleanup CodeChecker Errors

Removed the following error messages:
bugprone-unused-raii
  - object destroyed immediately after creation; did you mean to name
  the object
performance-move-const-arg
  - std::move of the variable 'maybeFallback' of the trivially-copyable
  type 'std::optional' has no effect; remove std::move()
clang-diagnostic-inconsistent-missing-override
  - 'interval' overrides a member function but is not marked 'override'

Change-Id: I0f6ab3002b7175a73449d58ea6ae6b66f7c851ef
Signed-off-by: Willy Tu <wltu@google.com>

test/watchdog.cpp

diff --git a/test/watchdog.cpp b/test/watchdog.cpp
index 7f0a2aa..3f0e06d 100644
--- a/test/watchdog.cpp
+++ b/test/watchdog.cpp
@@ -279,8 +279,7 @@
     fallback.always = false;
     wdog.reset();
     wdog = std::make_unique<Watchdog>(bus, TEST_PATH, event,
-                                      Watchdog::ActionTargetMap(),
-                                      std::move(fallback));
+                                      Watchdog::ActionTargetMap(), fallback);
     EXPECT_EQ(primaryInterval, milliseconds(wdog->interval(primaryIntervalMs)));
     EXPECT_FALSE(wdog->enabled());
     EXPECT_EQ(0, wdog->timeRemaining());
@@ -362,8 +361,7 @@
     fallback.always = false;
     wdog.reset();
     wdog = std::make_unique<Watchdog>(bus, TEST_PATH, event,
-                                      Watchdog::ActionTargetMap(),
-                                      std::move(fallback));
+                                      Watchdog::ActionTargetMap(), fallback);
     EXPECT_EQ(primaryInterval, milliseconds(wdog->interval(primaryIntervalMs)));
     EXPECT_FALSE(wdog->enabled());
     EXPECT_EQ(0, wdog->timeRemaining());
@@ -416,8 +414,7 @@
     fallback.always = false;
     wdog.reset();
     wdog = std::make_unique<Watchdog>(bus, TEST_PATH, event,
-                                      Watchdog::ActionTargetMap(),
-                                      std::move(fallback));
+                                      Watchdog::ActionTargetMap(), fallback);
     EXPECT_EQ(primaryInterval, milliseconds(wdog->interval(primaryIntervalMs)));
     EXPECT_FALSE(wdog->enabled());
     EXPECT_EQ(0, wdog->timeRemaining());