commit 022b6cf15cb41b3e7bedc33b98d2cfe5a5be83a0
author Gunnar Mills <gmills@us.ibm.com> Tue Sep 18 14:50:39 2018 -0500
committer Ed Tanous <ed.tanous@intel.com> Mon Oct 29 19:15:19 2018 +0000
tree 6b0b87e1037cdd6b36ab321354552bd6726f186b
parent 854fbba169307e14f27a3b1f840a802f068725c6

Remove SNMP Managers

Allow the user to remove SNMP Managers.
If the SNMP Manager being removed exists in the backend, make a
call to remove it.

Tested: Removed SNMP Managers on a Witherspoon
Change-Id: Ib392cda30754adfaa58f6301592c2d666ff2c29e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

app/configuration/controllers/snmp-controller.html

diff --git a/app/configuration/controllers/snmp-controller.html b/app/configuration/controllers/snmp-controller.html
index 2458e3d..3fd9aa3 100644
--- a/app/configuration/controllers/snmp-controller.html
+++ b/app/configuration/controllers/snmp-controller.html
@@ -9,15 +9,16 @@
       </div>
       <fieldset>
         <div class="row column snmp__managers-wrap">
-          <div class="snmp__managers" ng-repeat="manager in managers">
-            <div class="inline snmp__manager-field">
+          <div class="snmp__managers" ng-repeat="manager in managers track by $index">
+            <div class="snmp__manager-field">
               <label>SNMP Manager Server</label>
-              <input id="snmp-manager{{$index+1}}-address" type="text" ng-model="manager.address" ng-blur="managers[$index].address = manager.address"/>
+              <input class="inline" id="snmp-manager{{$index+1}}-address" type="text" ng-model="manager.address" ng-blur="managers[$index].address = manager.address"/>
             </div>
-            <div class="inline  snmp__manager-field">
+            <div class="snmp__manager-field">
               <label>Port</label>
-              <input id="snmp-manager{{$index+1}}-port" type="text" ng-model="manager.port" ng-blur="managers[$index].port = manager.port"/>
+              <input class="inline" id="snmp-manager{{$index+1}}-port" type="text" ng-model="manager.port" ng-blur="managers[$index].port = manager.port"/>
             </div>
+          <button class="snmp__manager-remove" ng-click="removeSNMPManager($index)">Remove</button>
           </div>
           <button type="button" class="btn-primary inline" ng-click="addNewSNMPManager()">Add SNMP manager</button>
         </div>

app/configuration/styles/snmp.scss

diff --git a/app/configuration/styles/snmp.scss b/app/configuration/styles/snmp.scss
index eabfb7a..1afefd0 100644
--- a/app/configuration/styles/snmp.scss
+++ b/app/configuration/styles/snmp.scss
@@ -10,8 +10,11 @@
   }
 
    .snmp__manager-field {
+    display:inline-block;
     padding-right: 4em;
     width: 350px;
+    padding-top: .6em;
+    padding-left: 0em;
   }
 
   .snmp__metadata-wrapper {
@@ -36,4 +39,13 @@
       margin: .5em;
     }
   }
+  .snmp__manager-remove {
+    display:inline-block;
+    color: $medblue;
+    height: 2.1em;
+    opacity: 1;
+    &:hover {
+      cursor: pointer;
+    }
+  }
 }