Remove vendors.js

hterm was removed in
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-webui/+/12603/
and vendors.js is no longer needed. No longer need to exclude
from gulp-options or from sonar as this directory no longer
exists.

Change-Id: Ib3e781174192d43b5e1dcf5d7390223d0261051c
Signed-off-by: beccabroek <beccabroek@gmail.com>
diff --git a/app/index.js b/app/index.js
index 9deca8a..cde0296 100644
--- a/app/index.js
+++ b/app/index.js
@@ -82,7 +82,6 @@
 import user_accounts_controller from './users/controllers/user-accounts-controller.js';
 
 import phosphor_templates from './templates.js';
-import phosphor_vendors from './vendors.js';
 
 window.angular && (function(angular) {
   'use strict';
@@ -95,8 +94,8 @@
             'ngRoute', 'angular-clipboard',
             'angularUtils.directives.dirPagination',
             // Basic resources
-            'app.templates', 'app.vendors', 'app.common.services',
-            'app.common.directives', 'app.common.filters',
+            'app.templates', 'app.common.services', 'app.common.directives',
+            'app.common.filters',
             // Model resources
             'app.login', 'app.overview', 'app.serverControl',
             'app.serverHealth', 'app.configuration', 'app.users',
diff --git a/app/vendors.js b/app/vendors.js
deleted file mode 100644
index 410520a..0000000
--- a/app/vendors.js
+++ /dev/null
@@ -1,12 +0,0 @@
-/**
- * A module to easily inject vendors dependencies as angular service
- *
- * @module app/vendors
- * @exports app/vendors
- */
-
-window.angular && (function(angular) {
-  'use strict';
-
-  angular.module('app.vendors', []);
-})(window.angular);
diff --git a/gulp-options.js b/gulp-options.js
index ea67708..6bfa74d 100644
--- a/gulp-options.js
+++ b/gulp-options.js
@@ -10,5 +10,4 @@
   'nodeModulesFolderPath': './node_modules',
   'bowerFolderPath': __dirname + '/bower_components',
   'dirname': __dirname,
-  'excludePath': '!./app/vendors/**/*'
 };
diff --git a/sonar-project.properties b/sonar-project.properties
index bcaa552..6b6029a 100644
--- a/sonar-project.properties
+++ b/sonar-project.properties
@@ -6,8 +6,6 @@
 # Comma-separated paths to directories with sources (required)
 sonar.sources=app
 
-sonar.exclusions=app/vendors/**/*.js
-
 # Language
 sonar.language=js