Resolve accessibility isssues
- Remove unecessary aria-roles
- Associate label elements with form elements
- Remove extraneous markup on Network settings page
- Update generic markup to use definition list when appropriate
- Add aria-labels and aria-expanded to accordion triggers
Tested: Accessibility issues tested in using Lighthouse in Chrome
Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels
set focus on the form elements. Visually tested of the Network
Settings page in Chrome, Firefox, and Safari to verify layout changes.
Resolves openbmc/phosphor-webui#76
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a
diff --git a/app/common/directives/app-header.html b/app/common/directives/app-header.html
index 8d6a2ad..050ac05 100644
--- a/app/common/directives/app-header.html
+++ b/app/common/directives/app-header.html
@@ -1,10 +1,10 @@
-<div id="header__wrapper">
+<header id="header" class="header">
<!-- HEADER -->
- <header id="header">
- <span class="header__title float-left">OpenBMC</span>
+ <div class="header__info-section">
+ <span class="header__title">OpenBMC</span>
<a href="" class="header__logout" ng-click="logout()">Log out</a>
- </header>
- <div class="header__functions-wrapper" role="heading">
+ </div>
+ <div class="header__functions-section">
<div class="logo__wrapper"><img src="../../assets/images/logo.svg" class="header__logo" alt="company logo"/></div>
<div class="inline header__server-name">
<p class="header__hostname">{{dataService.hostname}}</p>
@@ -26,4 +26,4 @@
</button>
</div>
</div>
-</div>
+</header>