commit 26539864e2aa078fa5d9723f05760a3068ce3bec
author Ed Tanous <ed.tanous@intel.com> Wed Aug 15 16:16:37 2018 -0700
committer Ed Tanous <ed.tanous@intel.com> Mon Aug 20 15:46:45 2018 +0000
tree 9d1d3c4099dacd7b968c931dad23bc73d4293b3f
parent ba7dad900c8c0ff4cc0043c3320ebf62c933cf0a

Turn uglification back on

Fixes github bug openbmc/openbmc#2871

Turn on uglification again.  It turns out, we only had one issue
preventing the UI from starting when running in uglified mode.  This
patchset fixes the issue, and reenables uglification.

This patchset drops our gzip compressed payload size by about 50K (about
14%).  While it doesn't seem like a lot now, it increases our ability
to scale the javascript payloads going forward.

Change-Id: I0744687203a9db0f4b26d1e1d2f4e3bdb4a52f78
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

app/server-health/controllers/log-controller.js

diff --git a/app/server-health/controllers/log-controller.js b/app/server-health/controllers/log-controller.js
index 4359c9c..68599f0 100644
--- a/app/server-health/controllers/log-controller.js
+++ b/app/server-health/controllers/log-controller.js
@@ -9,10 +9,13 @@
 window.angular && (function(angular) {
   'use strict';
   angular.module('app.serverHealth')
-      .config(function(paginationTemplateProvider) {
-        paginationTemplateProvider.setString(
-            require('../../common/directives/dirPagination.tpl.html'));
-      })
+      .config([
+        'paginationTemplateProvider',
+        function(paginationTemplateProvider) {
+          paginationTemplateProvider.setString(
+              require('../../common/directives/dirPagination.tpl.html'));
+        }
+      ])
       .controller('logController', [
         '$scope', '$window', 'APIUtils', 'dataService', 'Constants',
         '$routeParams', '$filter',

webpack.config.js

diff --git a/webpack.config.js b/webpack.config.js
index b82bbb9..6b3e899 100644
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -223,8 +223,7 @@
         // Reference:
         // http://webpack.github.io/docs/list-of-plugins.html#uglifyjsplugin
         // Minify all javascript, switch loaders to minimizing mode
-        // TODO: openbmc/openbmc#2871  Mangling currently breaks the GUI.
-        new UglifyJsPlugin({uglifyOptions: {mangle: false}}),
+        new UglifyJsPlugin(),
 
         // Copy assets from the public folder
         // Reference: https://github.com/kevlened/copy-webpack-plugin