Firmware page upload not working in some cases
Upload was not working in some cases because of two separate
issues. Inline onchange is no longer executed in Chrome. This
removes the inline onchange event since it was updating a variable
not being used anyway. This also updates the click-outside
directive as it was missing [ ] brackets that were necessary and
throwing an error in the console when loaded onto a witherspoon.
see https://developer.chrome.com/extensions/contentSecurityPolicy
and
https://stackoverflow.com/questions/35126898/error-after-minifica
tion-of-angular-js-error-injectorunpr-unknown-provider
Resolves openbmc/phosphor-webui#77
Tested: Able to upload image onto Witherspoon. Click-outside directive
worked when GUI was mounted on a Witherspoon
Change-Id: I7b1c385751e114b2d31f516e391dd0737117ab42
Signed-off-by: beccabroek <beccabroek@gmail.com>
diff --git a/app/common/directives/click-outside.js b/app/common/directives/click-outside.js
index ffe1464..35248ee 100644
--- a/app/common/directives/click-outside.js
+++ b/app/common/directives/click-outside.js
@@ -1,24 +1,26 @@
window.angular && (function(angular) {
'use strict';
- angular.module('app.common.directives')
- .directive('clickOutside', function($document) {
- return {
- restrict: 'A', scope: {clickOutside: '&'},
- link: function(scope, el, attr) {
- function clickEvent(e) {
- if (el !== e.target && !el[0].contains(e.target)) {
- scope.$apply(function() {
- scope.$eval(scope.clickOutside);
- });
- }
+ angular.module('app.common.directives').directive('clickOutside', [
+ '$document',
+ function($document) {
+ return {
+ restrict: 'A', scope: {clickOutside: '&'},
+ link: function(scope, el, attr) {
+ function clickEvent(e) {
+ if (el !== e.target && !el[0].contains(e.target)) {
+ scope.$apply(function() {
+ scope.$eval(scope.clickOutside);
+ });
}
- $document.bind('click', clickEvent);
-
- scope.$on('$destroy', function() {
- $document.unbind('click', clickEvent);
- });
}
- }
- });
+ $document.bind('click', clickEvent);
+
+ scope.$on('$destroy', function() {
+ $document.unbind('click', clickEvent);
+ });
+ }
+ }
+ }
+ ]);
})(window.angular);
\ No newline at end of file