commit 57ed98ee456703d0567661a49348033ca0c29ab2
author Dixsie Wolmers <dixsiew@gmail.com> Fri Sep 06 10:36:25 2019 -0500
committer Gunnar Mills <gmills@us.ibm.com> Wed Sep 11 02:55:13 2019 +0000
tree 810a5beaea9b279c3b9be66f33b562d4cdeb0bee
parent 219738d2a11dc89f0f259fe99626802c18e6d3a8

Fix IE11 SNMP edit bug

- Removes edit button from form
- Removes focus-within (not compatible with IE11 and Edge)
  and pointer-event

Tested:
- Input fields are editable and can be saved
- DAP violations and page layout consistency will be addressed
  in separate commit

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I2ccd06802137c2969fec686abc5b5f8e785725b6

app/configuration/controllers/snmp-controller.html

diff --git a/app/configuration/controllers/snmp-controller.html b/app/configuration/controllers/snmp-controller.html
index aa61f64..45ef681 100644
--- a/app/configuration/controllers/snmp-controller.html
+++ b/app/configuration/controllers/snmp-controller.html
@@ -68,18 +68,17 @@
                   </div>
                 </fieldset>
               </div>
-              <div class="small-2 align-self-center snmp__buttons">
-                <button class="btn edit_button" type="button">
-                  <icon file="icon-edit.svg" aria-label="Edit"></icon>
+              <div class="small-1 align-self-center snmp__buttons trash">
+                <button
+                  class="btn trash_button"
+                  type="button"
+                  ng-click="removeSNMPManager($index)"
+                  aria-label="Remove">
+                  <icon file="icon-trashcan.svg" aria-hidden="true"></icon>
                 </button>
               </div>
             </div>
           </div>
-          <div class="small-1 align-self-center snmp__buttons trash">
-            <button class="btn trash_button" type="button" ng-click="removeSNMPManager($index)">
-              <icon file="icon-trashcan.svg" aria-label="Remove"></icon>
-            </button>
-          </div>
         </div>
         <div class="row column">
           <button class="btn  btn-tertiary  btn-add" type="button" ng-click="submitted=false; addNewSNMPManager();">

app/configuration/styles/snmp.scss

diff --git a/app/configuration/styles/snmp.scss b/app/configuration/styles/snmp.scss
index f7df1c4..08429c8 100644
--- a/app/configuration/styles/snmp.scss
+++ b/app/configuration/styles/snmp.scss
@@ -15,12 +15,10 @@
     display: none;
   }
   .manager_group {
-    border-bottom: 1px solid $border-color-02;
     &.ng-invalid {
       input {
         color: black;
         border-style: solid;
-        pointer-events: auto;
       }
       .help__text {
         display: block;
@@ -43,27 +41,7 @@
   .snmp__address {
     padding: .3em 1em .3em 0;
   }
-  .snmp__fields {
-    input {
-      border-style: none;
-      pointer-events: none;
-      color: $text-02;
-      height: 2.4em;
-    }
-    &:focus-within {
-      input {
-        color: $primary-dark;
-        border-style: solid;
-        pointer-events: auto;
-      }
-      .form-error {
-        display: block;
-      }
-      .help__text {
-        display: block;
-      }
-    }
-  }
+
   .snmp__buttons {
     text-align: right;
     .btn{