Move bmc_firmware to displayBMCInfo

Before setting the BMC firmware was in displayServerInfo

Tested: Verified the BMC firmware still displays correctly.
Change-Id: Ic6323bc9eec700ff5956868899ccda398a841274
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff --git a/app/overview/controllers/system-overview-controller.js b/app/overview/controllers/system-overview-controller.js
index 812218c..2e27a66 100644
--- a/app/overview/controllers/system-overview-controller.js
+++ b/app/overview/controllers/system-overview-controller.js
@@ -50,12 +50,14 @@
                         $scope.displayLogs(data.logs.data);
                         $scope.displayServerInfo(
                             data.server_info,
-                            data.firmware.bmcActiveVersion,
                             data.firmware.hostActiveVersion
                         );
                         $scope.displayLEDState(data.led);
                         $scope.displayBMCEthernetInfo(data.ethernet);
-                        $scope.displayBMCInfo(data.bmc_info);
+                        $scope.displayBMCInfo(
+                            data.bmc_info,
+                            data.firmware.bmcActiveVersion
+                        );
                         $scope.displayPowerConsumption(data.power_consumption);
                         $scope.displayPowerCap(data.power_cap);
                       })
@@ -67,8 +69,9 @@
                     $scope.mac_address = data.MACAddress;
                 }
 
-                $scope.displayBMCInfo = function(data){
+                $scope.displayBMCInfo = function(data, bmcActiveVersion){
                     $scope.bmc_info = data;
+                    $scope.bmc_firmware = bmcActiveVersion;
                 }
 
                 $scope.displayLogs = function(data){
@@ -77,9 +80,8 @@
                     });
                 }
 
-                $scope.displayServerInfo = function(data, bmcActiveVersion, hostActiveVersion){
+                $scope.displayServerInfo = function(data, hostActiveVersion){
                     $scope.server_info = data.data;
-                    $scope.bmc_firmware = bmcActiveVersion;
                     $scope.server_firmware = hostActiveVersion;
                 }