Revert "WebUI: Sensors page modifications"
This reverts commit 2f481e4cb83f0c72a9f3aad11431e4abcf5d632c.
"/xyz/openbmc_project/sensors/power/" sensors (e.g. p0_vcs_power)
and "/xyz/openbmc_project/sensors/current/" sensors
(e.g. p0_vcs_current) are no longer on the GUI Sensors Page.
Since all sensors do not map to Thermal or Power, the
SensorCollection, /redfish/v1/Chassis/{ChassisId}/Sensors,
needs to be implemented before we move the GUI sensors page
over to Redfish.
The SensorCollection contains all sensors not covered elsewhere
in the model.
The SensorCollection will contain all sensors under
/current and all non-powersupply sensors under /power.
IBM is planning on working on the SensorCollection, it will be
sometime before the code is in because of this, reverting
moving the GUI sensor page over to Redfish.
Apologies on not catching this in the review.
For more information see:
https://redfishforum.com/thread/190/sensorcollection-contain-all-sensors-chassis
https://redfish.dmtf.org/schemas/SensorCollection.json
Tested: The current and power sensors are back on the Sensor page.
Change-Id: Ia818fc05b49a8181b71f8756a6066c27e94dc46e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff --git a/app/server-health/styles/sensors.scss b/app/server-health/styles/sensors.scss
index 074d27b..041a1e5 100644
--- a/app/server-health/styles/sensors.scss
+++ b/app/server-health/styles/sensors.scss
@@ -37,15 +37,35 @@
}
}
-.sensor__table {
- width: auto;
- min-width: 60%;
+.sensor__title {
+ min-width: 28%;
+ margin-bottom: 0;
+}
+
+.sensor__reading {
+ width: 100%;
+ text-align: right;
+ margin-bottom: 0;
+ display: none;
+ @include mediaQuery(medium) {
+ display: inline-block;
+ width: auto;
+ min-width: calc(70% * (1 / 5) - 18px);
+ }
+}
+
+.sensor__readings-row {
+ width: 100%;
+ position: relative;
+ display: block;
margin: 0;
background: $white;
text-decoration: none;
border: 1px solid $medgrey;
background: lighten($lightgrey,1%);
+ margin-top: 1em;
@include mediaQuery(medium) {
+ padding: .3em 1em .3em 1.5em;
margin-top: 0;
border-top: 0;
background: transparent;
@@ -53,54 +73,75 @@
.sensor__title {
font-weight: 700;
background: darken($lightgrey, 5%);
- min-width: 25%;
- overflow: visible;
+ min-width: 100%;
+ padding: .8em;
@include mediaQuery(medium) {
- min-width: 25%;
+ min-width: 30%;
background: transparent;
+ padding: .5em .5em .5em 0;
+ }
+ .icon__normal {
+ width: 0;
}
}
- .sensor__reading,
- .sensor__status {
+ .content-label {
+ font-size: 1em;
+ margin-left: .8em;
+ color: $darkgrey;
+ }
+ .sensor__reading {
+ @include fontCourierBold;
display: block;
- min-width: 15%;
- overflow: visible;
+ padding: .3em .8em;
@include mediaQuery(medium) {
display: inline-block;
+ padding: 0;
}
}
- .sensor__threshold {
- display: block;
- overflow: visible;
+ .sensor__current {
+ background: darken($thresh-normal, 3%);
+ margin: 0;
@include mediaQuery(medium) {
- display: inline-block;
+ background: $thresh-normal;
+ padding: .7em .3em;
+ margin-left: 10px;
+ min-width: 109px;
+ }
+ @include mediaQuery(large) {
+ background: $thresh-normal;
+ padding: .7em;
+ margin-left: .3em;
+ margin-right: .3em;
+ min-width: 150px;
+ }
+ .sensor__label {
+ font-weight: 700;
+ @include mediaQuery(medium) {
+ font-weight:300;
+ }
}
}
- .sensor__Critical {
+ .sensor__critical {
background: $thresh-critical;
color: $white;
.content-label {
color: $white;
}
}
- .sensor__Warning {
+ .sensor__warn {
background: $thresh-warning;
color: $black;
.content-label {
color: $black;
}
}
- .sensor__OK {
- background: $thresh-normal;
- color: $black;
- .content-label {
- color: $black;
- }
- }
+
}
// Sensors
+
#sensors, #sensors-overview {
+
.toggle-filter {
margin-bottom: 20px;
}
@@ -108,27 +149,6 @@
padding-left: 0px;
padding-right: 0px;
}
- .dropdown__button {
- margin-bottom: 1.2em;
- }
- .dropdown__list {
- margin-top: -17px;
- }
- .dropdown__button {
- width: 25em;
- margin-top: 0;
- text-align: left;
- border: 0.1em solid;
- }
- .dropdown__wrapper {
- width: 25em;
- margin-top: 0.4em;
- text-align: left;
- }
- .select__filter {
- margin-bottom: 20px;
- margin-left: 15px;
- }
}
//end sensor details