Fix change priority down arrow logic
If the Boot priority was an "Active" image then a "Functional" image.
The down arrow would be grayed out on the "Active" image.
It should not have been grayed out, i.e. the user should be able to
lower the priority on an "Active" image if there is a functional
image below it in the table.
Resolves openbmc/openbmc#3228
Tested: Tested this case and uploaded an image of the result to 3228.
Change-Id: I6033886354f76671a4d33c4d8a79097428311e93
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff --git a/app/common/directives/firmware-list.html b/app/common/directives/firmware-list.html
index 547aa6c..16554d9 100644
--- a/app/common/directives/firmware-list.html
+++ b/app/common/directives/firmware-list.html
@@ -28,8 +28,8 @@
ng-click="!$first && changePriority(firmware.imageId, firmware.Version, firmware.Priority, firmware.Priority - 1)"
ng-show="firmware.activationStatus == 'Functional' || firmware.activationStatus == 'Active'">
<span class="accessible-text">firmware up in priority</span></div>
- <div class="icon icon__down-arrow" aria-hidden="true" ng-class="{'icon-as-spacer':$last || imageList[$index+1].activationStatus != 'Active'}"
- ng-click="(!$last && imageList[$index + 1].activationStatus == 'Active') && changePriority(firmware.imageId, firmware.Version, firmware.Priority, firmware.Priority + 2)"
+ <div class="icon icon__down-arrow" aria-hidden="true" ng-class="{'icon-as-spacer':$last || !['Active', 'Functional'].includes(imageList[$index+1].activationStatus)}"
+ ng-click="(!$last && ['Active', 'Functional'].includes(imageList[$index + 1].activationStatus)) && changePriority(firmware.imageId, firmware.Version, firmware.Priority, firmware.Priority + 2)"
ng-show="firmware.activationStatus == 'Functional' || firmware.activationStatus == 'Active'">
<span class="accessible-text">firmware down in priority</span></div>
</div>