Add loading spinner
Added a loading spinner that appears when set network settings are
confirmed. This fits with the other pages such as firmware update.
Tested: See the spinner when Save settings are confirmed.
Change-Id: Iec321e036ad7a81d960109397b3a60ffdf256062
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff --git a/app/configuration/controllers/network-controller.js b/app/configuration/controllers/network-controller.js
index 3f7cebe..cc803d7 100644
--- a/app/configuration/controllers/network-controller.js
+++ b/app/configuration/controllers/network-controller.js
@@ -23,6 +23,7 @@
$scope.set_network_success = false;
$scope.selectedInterface = '';
$scope.confirm_settings = false;
+ $scope.loading = false;
$scope.selectInterface = function(interfaceId) {
$scope.interface = $scope.network.interfaces[interfaceId];
@@ -36,6 +37,7 @@
$scope.confirm_settings = false;
$scope.set_network_error = '';
$scope.set_network_success = false;
+ $scope.loading = true;
var promises = [];
// MAC Address are case-insensitive
@@ -67,13 +69,14 @@
}
}
- if (promises.length) {
- $q.all(promises).finally(function() {
- if (!$scope.set_network_error) {
- $scope.set_network_success = true;
- }
- });
- }
+ $q.all(promises).finally(function() {
+ $scope.loading = false;
+ // $q.all with an empty array resolves immediately but don't show
+ // the success message
+ if (!$scope.set_network_error && promises.length) {
+ $scope.set_network_success = true;
+ }
+ });
};