commit 9aee5e672b5429169a299494f368f9c4498432bf
author Gunnar Mills <gmills@us.ibm.com> Mon Oct 14 11:34:57 2019 -0500
committer Gunnar Mills <gmills@us.ibm.com> Thu Oct 17 15:53:44 2019 +0000
tree 3375f7f4b209057de6521d1f8ece95103a968d04
parent 365b80eb5dd50db8adcc0bb75cf946fecc32cb46

DNS: Remove workaround for empty list array

This workaround is no longer needed with bmcweb.

curl  -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [] }' \
https://${bmc}/xyz/openbmc_project/network/eth0/attr/Nameservers
{
  "data": null,
  "message": "200 OK",
  "status": "ok"

and actually casues an error now do to
https://github.com/openbmc/phosphor-networkd/commit/5fb6c33a49ee2b9718cc9ce0f921d3b6cf38a463

curl  -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [""] }' \
https://${bmc}/xyz/openbmc_project/network/eth0/attr/Nameservers
  "data": {
    "description": "xyz.openbmc_project.Common.Error.InvalidArgument"
  },
  "message": "Invalid argument was given.",

See https://github.com/openbmc/openbmc/issues/3240

Tested: Built and loaded on a Witherspoon. Added, removed,
        and edited DNS servers.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Change-Id: I278489a8c4682641b61a0e5ab08fd714603b0234

app/configuration/controllers/network-controller.js

diff --git a/app/configuration/controllers/network-controller.js b/app/configuration/controllers/network-controller.js
index 07a810c..0eee6fb 100644
--- a/app/configuration/controllers/network-controller.js
+++ b/app/configuration/controllers/network-controller.js
@@ -211,11 +211,6 @@
       }
 
       function setNameservers() {
-        // Nameservers does not allow an empty array, since we remove all empty
-        // strings above, could have an empty array. TODO: openbmc/openbmc#3240
-        if ($scope.interface.Nameservers.length == 0) {
-          $scope.interface.Nameservers.push('');
-        }
         return APIUtils
             .setNameservers(
                 $scope.selectedInterface, $scope.interface.Nameservers)