Consolidate button styles
This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.
This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.
- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
diff --git a/app/configuration/controllers/date-time-controller.html b/app/configuration/controllers/date-time-controller.html
index 8ea478a..d84d278 100644
--- a/app/configuration/controllers/date-time-controller.html
+++ b/app/configuration/controllers/date-time-controller.html
@@ -19,11 +19,11 @@
<div class="inline">
<input id="ntp-server{{$index+1}}" type="text" ng-readonly="time.mode != 'NTP'" ng-model="server" ng-blur="ntp.servers[$index] = server" set-focus-on-new-input/>
</div>
- <button class="date-time__dns-remove inline" ng-click="removeNTPField($index)">Remove</button>
+ <button class="btn date-time__dns-remove btn-tertiary" ng-click="removeNTPField($index)">Remove</button>
</fieldset>
</div>
<div class="row column date-time__ntp-servers-wrap">
- <button type="button" class="btn-primary block" ng-click="addNTPField()">Add new NTP server</button>
+ <button type="button" class="btn btn-primary" ng-click="addNTPField()">Add new NTP server</button>
</div>
<div class="row column">
<label class="control-radio" for="manual-time">Manually set date and time
@@ -59,8 +59,8 @@
</div>
</fieldset>
<div class="time__submit-wrapper">
- <button type="button" class="btn-primary inline" ng-click="setTime()">Save settings</button>
- <button type="button" class="btn-secondary inline" ng-click="refresh()">Cancel</button>
+ <button type="button" class="btn btn-primary" ng-click="setTime()">Save settings</button>
+ <button type="button" class="btn btn-secondary" ng-click="refresh()">Cancel</button>
</div>
</form>
</div>