tree 59c398cc8f3fd85a1cf624a276cbe67ae4de506f
parent 2e1eec80de6c8e9a2bd7c813c9e9ff31038e0906
author Ed Tanous <ed@tanous.net> 1594909987 -0700
committer Ed Tanous <ed@tanous.net> 1595463161 -0700

Drop encoding library

Commit f4a43cca440535a63592877c9bdbbe28636d803c attempted to fix a IE
bug in the SOL library.  Unfortunately, it did it by pulling in the
entire NPM encoding library, which is insanely large (190kb after
minification and compression).  This is almost equivalent to the rest of
our javascript put together!  That's nuts, and I don't think anyone
would argue that's a binary hit worth taking for IE9 support.

This commit removes it, and swaps in an inline polyfill from the mozilla
recommendations, that compresses much....much smaller.

Before this patchset build prints:
app.bundle.js.gz    522 KiB          [emitted]  [big]

After this patchset:
app.bundle.js.gz    332 KiB          [emitted]  [big]

If you don't want to break out a calculator, that's 190KB savings in the
root filesystem, and should cut the initial page load time (on slow
connections) by nearly 30 percent.

Note: text-encodings was never pinned in the package-lock.json, hence
why you don't see a diff removing it from package lock.  This was a miss
on the original commiters part, although it doesn't really matter, as
it's now removed.

PS: A reviewer may note, I could've moved the polyfill into its own
file.  Considering the serial console is the only page that uses that,
and it's not that big I elected not to, to make removing it analagous
with removing xterm/the serial console.

Bonus content!
Added a (commented out) webpack config that allows you to generate the
webui as individual gzipped fragments, instead of one bundle.  This
allows you to see file sizes on a package by package basis, and was how
I found this commit in question.

Testing:
This is where this patchset gets hairy.  I dont' have an IE9 instance to
test on.  Given it's low usage, and the fact that it's a relatively
straightforward change we can probably just wait for someone to tell us
it's broken again.

Enjoy the sweet sweet savings.

Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I2820ff1c4b33d725ebc63490793a72fe600b8ed3
Signed-off-by: Ed Tanous <ed@tanous.net>